Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Asciidoctor version number management #72

Closed
dduportal opened this issue May 16, 2018 · 0 comments
Closed

Improve Asciidoctor version number management #72

dduportal opened this issue May 16, 2018 · 0 comments

Comments

@dduportal
Copy link
Contributor

So the Asciidoctor's version is currently written in 3 locations into the repository:

  • Into the Makefile as a an expected single entrypoint (it is propagated to the docker build command as build argument + it is passed as environment variable to the test suite).
  • Into the Dockerfile as default value for the ARG ASCIIDOCTOR_VERSION directive:
    • This is overwritten during the Travis Build
    • But the DockerHub was not providing parameterized build capability when the new build process was done.
  • Into the README.adoc as sharply caught by @mojavelinux in Asciidoctor to 1.5.7.1 #71

The goal of this issue is to track the work related to having a single location.

PS: Might be linked with #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant