You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So the Asciidoctor's version is currently written in 3 locations into the repository:
Into the Makefile as a an expected single entrypoint (it is propagated to the docker build command as build argument + it is passed as environment variable to the test suite).
Into the Dockerfile as default value for the ARG ASCIIDOCTOR_VERSION directive:
This is overwritten during the Travis Build
But the DockerHub was not providing parameterized build capability when the new build process was done.
So the Asciidoctor's version is currently written in 3 locations into the repository:
Makefile
as a an expected single entrypoint (it is propagated to thedocker build
command as build argument + it is passed as environment variable to the test suite).Dockerfile
as default value for theARG ASCIIDOCTOR_VERSION
directive:README.adoc
as sharply caught by @mojavelinux in Asciidoctor to 1.5.7.1 #71The goal of this issue is to track the work related to having a single location.
PS: Might be linked with #54
The text was updated successfully, but these errors were encountered: