Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version regex #1

Closed
clatko opened this issue Jan 16, 2018 · 6 comments
Closed

version regex #1

clatko opened this issue Jan 16, 2018 · 6 comments

Comments

@clatko
Copy link

clatko commented Jan 16, 2018

This should probably be brought up in the main asdf community, but a semver regex should be applied for installation. With kubectl plugin I can do asdf install kubectl 1.8, then it becomes pretty difficult to purge my machine of this faulty version number.

@jthegedus
Copy link

This is related to asdf-vm/asdf#216

@DustinChaloupka
Copy link
Contributor

This should already be handled by the default latest command provided by asdf.

@jthegedus
Copy link

@DustinChaloupka asdf latest essentially runs tail on the list-all result.

asdf-vm/asdf#763 tracks work to make asdf latest defer to the plugin so more complex situations can be supported. If the upstream changes from semver to v-prefixed semver or vice versa, then the core isn't going to know which is the latest without knowledge of the upstream, hence, the plugin author is best to make these decisions and the 763 will accomodate this workflow for proper ordering.

@DustinChaloupka
Copy link
Contributor

This plugin sorts the versions which are semver formatted and do not have a v prefix, so the fallback mechanism from the implementation of asdf-vm/asdf#736 would still allow this plugin to correctly give the latest version. Am I missing something?

@jthegedus
Copy link

@DustinChaloupka Indeed you are correct. Sorry, I may have replied to the wrong issue.

@DustinChaloupka
Copy link
Contributor

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants