Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array compression for non-native byte order #1010

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Fix array compression for non-native byte order #1010

merged 2 commits into from
Aug 16, 2021

Conversation

lgarrison
Copy link
Contributor

Use a round-trip to Numpy to create a 1D memoryview that has the right byte order, because memoryview can't cast to all types it can represent.

Closes #1009.

@eslavich eslavich self-requested a review August 16, 2021 17:01
@eslavich eslavich added this to the 2.8.2 milestone Aug 16, 2021
eslavich
eslavich approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@eslavich eslavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidy fix, thanks a lot!

@eslavich eslavich merged commit 8bcd0a5 into asdf-format:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eslavich eslavich eslavich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.2
Development

Successfully merging this pull request may close these issues.

Array compression fails for non-native byte order
2 participants
@lgarrison @eslavich