Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate find_references calls during AsdfFile.__init__ and open #1708

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Dec 16, 2023

Description

Deprecate the automatic calling of AsdfFile.find_references during AsdfFile.__init__ and asdf.open. A warning will only appear if a reference is found. References appear to be unused in all known downstream packages so I don't expect we will see any of these warnings. find_references walks and modifies (so performs a deep copy of) the tree so the eventual removal of this automatic calling should speed up most calls to AsdfFile.__init__ and asdf.open.

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@braingram braingram marked this pull request as ready for review December 16, 2023 17:51
@braingram braingram requested a review from a team as a code owner December 16, 2023 17:51
Copy link
Contributor

@eslavich eslavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gain some time back, lose... nothing useful. If super-dictionaries catch on then we'll have a natural way to lazy load references too.

@braingram braingram merged commit a6ec390 into asdf-format:main Dec 18, 2023
46 checks passed
@braingram braingram deleted the deprecate_auto_find_ref branch December 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants