Better handling of AsdfInFits #241
Merged
+194
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit introduced a bug in the _open_impl method of AsdfFile. This commit fixes that bug and changes the use of kwargs in that method back to an explicit argument list.
|
Looks reasonable to me. |
|
@drdavella This needs a change log entry. |
|
@drdavella I forgot to mention that we have adopted the convention to use the pull request number in Could you add a test case and perhaps an example in the docs. I am currently getting an error trying this with a fits file but my setup may be the problem. |
|
I added an issue (#246) to address the bug you were seeing with missing extensions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #182 proposed more intelligent handling of FITS files with ASDF extensions. This branch allows
AsdfInFits.opento handle URIs, open file handles, and HDULists, whereas previously it only handled HDULists. Also,AsdfFile.opennow attempts to handle FITS files with ASDF extensions if the given file-like object is not obviously ASDF. Comments on implementation, code style, documentation, etc. welcome.