Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICRSCoord tag implementation is moving to astropy #401

Merged
merged 10 commits into from
Dec 8, 2017
Merged

ICRSCoord tag implementation is moving to astropy #401

merged 10 commits into from
Dec 8, 2017

Conversation

drdavella
Copy link
Contributor

No description provided.

@drdavella drdavella added this to the v2.0.0 milestone Nov 28, 2017
@drdavella drdavella requested a review from nden November 28, 2017 21:30
@stsci-bot
Copy link

stsci-bot bot commented Nov 28, 2017 •
edited
Loading

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@drdavella drdavella mentioned this pull request Nov 28, 2017
Merged
nden
nden approved these changes Dec 1, 2017
View reviewed changes
Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should the tests be passing?

@drdavella
Copy link
Contributor Author

@nden yes, actually this PR needs a little more work. I'm looking into it now and I can let you know when the tests pass.

@drdavella drdavella force-pushed the relocate-icrs-coord branch from 6a9625a to 0fd07c5 Compare December 1, 2017 17:35
@drdavella
Schema validation should use all installed resolvers...
0fd07c5 
Using the resolver of an actual AsdfFile context instead of the default
resolver allows any extensions that were installed as entry points to be
used as part of schema validation.
@drdavella
Temporary updates to CI scripts to test against feature branch
a4e22b9
@drdavella drdavella mentioned this pull request Dec 1, 2017
Merged
@drdavella
Copy link
Contributor Author

drdavella commented Dec 1, 2017 •
edited
Loading

NOTE: the following things need to happen before merging:

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.958% when pulling a4e22b9 on drdavella:relocate-icrs-coord into b81c7ae on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.958% when pulling 90045c2 on drdavella:relocate-icrs-coord into b81c7ae on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 95.148% when pulling 15f8f09 on drdavella:relocate-icrs-coord into b81c7ae on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 95.148% when pulling 760f51b on drdavella:relocate-icrs-coord into b81c7ae on spacetelescope:master.

@drdavella drdavella merged commit 01e14dd into asdf-format:master Dec 8, 2017
@drdavella drdavella deleted the relocate-icrs-coord branch December 11, 2017 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@drdavella @coveralls @nden