-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update complex number schema and add tests #526
Conversation
Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
Added a change log entry since this change has the potential (however minimal) to affect the behavior of |
bc036f5
to
2fee7ff
Compare
This PR addresses several outstanding problems with the schema for complex numbers. It adds much more thorough tests of the schema and ensures that improperly formatted complex numbers are detected by a schema validation error (which was not previously the case).
In a way, this is a fairly substantial change since it imposes much more stringent requirements on the format of complex numbers. However, since these requirements were implicit to begin with and should have been enforced in the first place, it seems unlikely that anyone is using files that are in conflict with the new rules.
This is closely related to asdf-format/asdf-standard#171 and integrates the updates to the schema that were introduced there.