Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update complex number schema and add tests #526

Merged
merged 10 commits into from
Aug 3, 2018

Conversation

drdavella
Copy link
Contributor

This PR addresses several outstanding problems with the schema for complex numbers. It adds much more thorough tests of the schema and ensures that improperly formatted complex numbers are detected by a schema validation error (which was not previously the case).

In a way, this is a fairly substantial change since it imposes much more stringent requirements on the format of complex numbers. However, since these requirements were implicit to begin with and should have been enforced in the first place, it seems unlikely that anyone is using files that are in conflict with the new rules.

This is closely related to asdf-format/asdf-standard#171 and integrates the updates to the schema that were introduced there.

@drdavella drdavella added this to the 2.0.3 milestone Aug 3, 2018
@drdavella drdavella self-assigned this Aug 3, 2018
@stsci-bot
Copy link

stsci-bot bot commented Aug 3, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@coveralls
Copy link

coveralls commented Aug 3, 2018

Coverage Status

Coverage decreased (-0.003%) to 93.798% when pulling 2fee7ff on drdavella:add-complex-tests into 37d57aa on spacetelescope:master.

@drdavella
Copy link
Contributor Author

Added a change log entry since this change has the potential (however minimal) to affect the behavior of asdf when reading files with ill-formed complex numbers.

@drdavella drdavella merged commit 9961e26 into asdf-format:master Aug 3, 2018
@drdavella drdavella deleted the add-complex-tests branch August 3, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants