Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom warning class for failure to convert into custom types #583

Merged
merged 4 commits into from
Oct 31, 2018

Conversation

drdavella
Copy link
Contributor

This resolves #582.

@drdavella drdavella added this to the v2.2.0 milestone Oct 30, 2018
@drdavella drdavella self-assigned this Oct 30, 2018
@stsci-bot
Copy link

stsci-bot bot commented Oct 30, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

3 similar comments
@stsci-bot
Copy link

stsci-bot bot commented Oct 30, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@stsci-bot
Copy link

stsci-bot bot commented Oct 30, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@stsci-bot
Copy link

stsci-bot bot commented Oct 30, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 93.692% when pulling 1f8d033 on drdavella:conversion-warning into 32abe89 on spacetelescope:master.

@drdavella drdavella merged commit eae035d into asdf-format:master Oct 31, 2018
@drdavella drdavella deleted the conversion-warning branch October 31, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use custom warning type when failing to deserialize tree
2 participants