Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path handling on Windows #632

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

drdavella
Copy link
Contributor

No description provided.

@drdavella drdavella added this to the v2.3.1 milestone Dec 18, 2018
@drdavella drdavella self-assigned this Dec 18, 2018
@stsci-bot
Copy link

stsci-bot bot commented Dec 18, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@coveralls
Copy link

coveralls commented Dec 18, 2018

Coverage Status

Coverage decreased (-0.01%) to 95.009% when pulling cddd73e on drdavella:fix-atomic-windows into 1398fdf on spacetelescope:master.

@drdavella
Copy link
Contributor Author

I'm going to wait to see whether this resolves @Cadair's issue before merging.

@Cadair
Copy link
Contributor

Cadair commented Dec 20, 2018

Ok this now seems to have fixed it.

@drdavella drdavella changed the title Attempt a fix for writing atomic files on Windows Fix path handling on Windows Dec 20, 2018
@drdavella drdavella added the bug label Dec 20, 2018
@drdavella drdavella merged commit f0c6c9c into asdf-format:master Dec 20, 2018
@drdavella drdavella deleted the fix-atomic-windows branch December 20, 2018 14:15
@Cadair
Copy link
Contributor

Cadair commented Dec 20, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants