replace SpecItem with SimpleSpec #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't need support for <2.8. If one would backport asdf (to Debian Buster f.e.), they would just need to backport semantic-version as well, which is acceptable. So, I am in favour for this PR. |
|
Note: The only valid test here is the one with astrodev (passing). The rest fail because they use the public release of astropy and references to new models are missing. |
jdavies-st
reviewed
Nov 15, 2019
| @@ -31,7 +31,7 @@ package_dir = | |||
| asdf.reference_files = asdf-standard/reference_files | |||
| include_package_data = True | |||
| install_requires = | |||
| semantic_version>=2.3.1,<=2.6.0 | |||
| semantic_version>=2.8 | |||
There was a problem hiding this comment.
Could this be relaxed to 2.7, when SimpleSpec was introduced? Or were functional changes made in 2.8 that we need?
There was a problem hiding this comment.
2.7 was a short lived release, looked like it wasn't stable.
perrygreenfield
approved these changes
Nov 15, 2019
jdavies-st
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #702
This PR replaces
SpecItemwithSimpleSpec(both fromsemantic_version).It also fixes the semantic_version to >= 2.8 . This is a backwards incompatible change in
semantic_versionso if we need to support earlier versions more changes will be needed.@olebole Do you think support for earlier versions is needed?