Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bother showing .tree in search result paths #875

Closed
eslavich opened this issue Sep 9, 2020 · 0 comments · Fixed by #954
Closed

Don't bother showing .tree in search result paths #875

eslavich opened this issue Sep 9, 2020 · 0 comments · Fixed by #954
Milestone

Comments

@eslavich
Copy link
Contributor

eslavich commented Sep 9, 2020

The search function returns paths like this:

["root.tree['meta']['wcs']",
 "root.tree['meta']['wcsinfo']",
 "root.tree['meta']['cal_step']['assign_wcs']",
 "root.tree['meta']['ref_file']['specwcs']",
 "root.tree['meta']['wcsinfo']['wcsaxes']"]

When I wrote that code, I didn't notice that this is also possible:

["root['meta']['wcs']",
 "root['meta']['wcsinfo']",
 "root['meta']['cal_step']['assign_wcs']",
 "root['meta']['ref_file']['specwcs']",
 "root['meta']['wcsinfo']['wcsaxes']"]

(The AsdfFile class implements a __getitem__ that fetches from the tree)

We ought to update the search paths to the more succinct option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant