Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defunct asdf.test method and use setuptools-scm to generate version file #943

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Remove defunct asdf.test method and use setuptools-scm to generate version file #943

merged 2 commits into from
Mar 22, 2021

Conversation

eslavich
Copy link
Contributor

@eslavich eslavich commented Mar 22, 2021 •
edited
Loading

Some cleanup of asdf.__init__:

  • Remove support for astropy test runner
  • Remove asdf.__githash__ which is always empty string
  • Use setuptools_scm version file template to write asdf/version.py
  • Update documentation on running the tests

Closes #692
Resolves #939

@eslavich eslavich requested a review from jdavies-st March 22, 2021 14:38
jdavies-st
jdavies-st approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I updated the PR comment to close a long-standing PR I had laying around here that attempted to update the version stuff. Yours is superior. 👍

@jdavies-st jdavies-st added this to the 2.8.0 milestone Mar 22, 2021
@eslavich eslavich merged commit 59e91f6 into asdf-format:master Mar 22, 2021
@eslavich eslavich deleted the AL-482-remove-defunct-test-method branch March 22, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavies-st jdavies-st jdavies-st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

internal tests failed: test_diff.py:57: AssertionError: assert main.main_from_args(['diff'] + paths) == 0
2 participants
@eslavich @jdavies-st