py311 compatibility #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python 3.11 prevents use of global flags not at the start of the regex. Mistune does something with the regex that conflicts with the use of a global flag (even at the start of the regex) and pre-compiling does not work. Instead of using DOTALL use [\w\W].
braingram
changed the title
This was referenced Jul 7, 2023
WilliamJamieson
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python 3.11 does not allow global regex flags unless they are at the start of the expression. mistune appears to do something with the regex before compiling which causes sphinx-asdf to fail under some circumstances in python 3.11 (as can be seen in this PR: spacetelescope/stdatamodels#178 and docs build: https://readthedocs.org/projects/stdatamodels/builds/21235549/)
This PR uses
[\w\W]instead of the dotall flag to be compatible with python 3.11 and adds 3.11 to the CI.