Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to keyring import for installed keys #208

Closed
vadave opened this issue Mar 5, 2021 · 1 comment
Closed

Add check to keyring import for installed keys #208

vadave opened this issue Mar 5, 2021 · 1 comment

Comments

@vadave
Copy link
Contributor

vadave commented Mar 5, 2021

I was working on some automation and discovered the keyring import function was taking a long time to run, even if the gpg keys had already been installed. Looking at the import-release-team-keyring script, I noticed that it doesn't check to see if the key is already installed locally before it queries the keyservers.

I've added a simple check in that function that will bypass the network calls if the key is already installed in the keyring. I'll submit a PR to address this.

@vadave
Copy link
Contributor Author

vadave commented Mar 11, 2021

PR has been merged. Closing. Thanks to the team for the great plugin.

@vadave vadave closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant