Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm global uninstall doesn't remove shims #89

Closed
torywheelwright opened this issue Aug 1, 2018 · 5 comments
Closed

npm global uninstall doesn't remove shims #89

torywheelwright opened this issue Aug 1, 2018 · 5 comments

Comments

@torywheelwright
Copy link

Installing another global package seems to call the postinstall script, which does remove the old and add the new. I'm not sure if NPM can be made to hook that script on uninstall as well?

@andys8
Copy link

andys8 commented Nov 19, 2018

Noticed it, too

@vic
Copy link
Contributor

vic commented Jan 19, 2019

On asdf master 0.6.4-dev there is now support for pre-post command hooks. Currently they are only read from the user's .asdfrc file (so, right now they are user specific and not shared code in the plugin's repo).

Here's an example for reshim after rust's cargo install, so I guess something similar could be made for npm uninstall -g ?

@lucascaton
Copy link

I can confirm this issue is still happening.

@augustobmoura
Copy link
Member

Should be fixed with #197

@augustobmoura
Copy link
Member

It should be fixed in master now, as we are not using post-install hooks anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants