fix "except" option handling (#1687)

lib/ash/notifier/pub_sub/pub_sub.ex

@@ -482,7 +482,7 @@ defmodule Ash.Notifier.PubSub do
 
   defp matches?(%{action: action}, %{name: action}), do: true
 
-  defp matches?(%{type: type, except: except}, %{type: type, action: action}) do
+  defp matches?(%{type: type, except: except}, %{type: type, name: action}) do
     action not in except
   end
 

test/notifier/pubsub_test.exs

@@ -30,6 +30,9 @@ defmodule Ash.Test.Notifier.PubSubTest do
       publish :update, ["foo", :id], previous_values?: true
       publish :update, ["bar", :name], event: "name_change", previous_values?: true
       publish :update_pkey, ["foo", :_pkey], previous_values?: true
+
+      publish_all :update, ["baz", :id], event: "any_update", except: [:update_pkey]
+      publish_all :update, ["fiz", :id], event: "any_update", except: [:doesnotexist]
     end
 
     ets do
@@ -160,6 +163,10 @@ defmodule Ash.Test.Notifier.PubSubTest do
     assert_receive {:broadcast, ^message, "name_change", %Ash.Notifier.Notification{}}
     message = "post:bar:ted"
     assert_receive {:broadcast, ^message, "name_change", %Ash.Notifier.Notification{}}
+    message = "post:baz:#{post.id}"
+    assert_receive {:broadcast, ^message, "any_update", %Ash.Notifier.Notification{}}
+    message = "post:fiz:#{post.id}"
+    assert_receive {:broadcast, ^message, "any_update", %Ash.Notifier.Notification{}}
   end
 
   test "publishing a message with a pkey matcher" do
@@ -179,6 +186,10 @@ defmodule Ash.Test.Notifier.PubSubTest do
 
     message = "post:foo:#{new_id}"
     assert_receive {:broadcast, ^message, "update_pkey", %Ash.Notifier.Notification{}}
+    message = "post:baz:#{new_id}"
+    refute_receive {:broadcast, ^message, "any_update", %Ash.Notifier.Notification{}}
+    message = "post:fiz:#{new_id}"
+    assert_receive {:broadcast, ^message, "any_update", %Ash.Notifier.Notification{}}
   end
 
   test "publishing a message with a different delimiter" do