Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return_notifications?: true should automatically set notify? to true #1100

Closed
frankdugan3 opened this issue May 2, 2024 · 0 comments
Closed

fix: return_notifications?: true should automatically set notify? to true #1100

frankdugan3 opened this issue May 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@frankdugan3
Copy link
Contributor

Describe the bug

Currently, when using return_notifications?: true, you also have to set notify?: true or no notifications will be generated. This is confusing and a bit of a footgun, as there is probably not any use case for that behavior.

Ideally, notify? should be assumed to be true if return_notifications? is true.
@frankdugan3 frankdugan3 added bug Something isn't working needs review labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachdaniel @frankdugan3