Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim spaces from codegen name #1106

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

bopm
Copy link
Contributor

@bopm bopm commented May 2, 2024

This PR addresses the possibility of running mix ash.codegen <something><tailing space> which leads to a migration file name and migration name containing the same space (e.g. creating priv/repo/migrations/name .exs and ...Repo.Migrations.Name ".up/0 forward.

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

Not applicable, as there are no specs for that.

@zachdaniel zachdaniel merged commit 0efa1a0 into ash-project:main May 2, 2024
25 of 30 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

@bopm bopm deleted the patch-1 branch May 2, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants