Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve original ordering in Util.Install #33

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix: preserve original ordering in Util.Install #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/igniter/util/install.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ defmodule Igniter.Util.Install do
end)
|> Stream.filter(&implements_behaviour?(&1, Igniter.Mix.Task))
|> Enum.filter(&(Mix.Task.task_name(&1) in desired_tasks))
|> Enum.sort_by(
&Enum.find_index(desired_tasks, fn e -> e == Mix.Task.task_name(&1) end),
&<=/2
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a cleaner approach here would be something like:

   available_igniter_tasks =
      Mix.Task.load_all()
      |> Stream.map(fn item ->
        Code.ensure_compiled!(item)
        item
       end)
       |> Stream.filter(&implements_behaviour?(&1, Igniter.Mix.Task))
       |> Enum.filter(&(Mix.Task.task_name(&1) in desired_tasks))

igniter_tasks = Enum.filter(desired_tasks, &(&1 in available_igniter_tasks))

? Maybe not though, they kind of both aren't 100% clear what's going on. I'll leave it up to you just LMK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tricky because desired_tasks would need to be converted from strings to modules before checking for in available_igniter_tasks. And the conversion is not deterministic, which is why we have load_all() |> map() |> filter(), right?


title =
case desired_tasks do
Expand Down
Loading