Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate provisional extensions by default #343

Open
MaikKlein opened this issue Dec 12, 2020 · 3 comments · May be fixed by #952
Open

Don't generate provisional extensions by default #343

MaikKlein opened this issue Dec 12, 2020 · 3 comments · May be fixed by #952
Labels
bug enhancement

Comments

@MaikKlein
Copy link
Member

MaikKlein commented Dec 12, 2020 •
edited
Loading

Some extensions are marked as provisional="true", and they are allowed to contain breaking changes.

Because ash follows semver like most rust crates, this isn't great.

We should either filter out those extensions or move them into an experimental folder where we don't adhere to semver.
@Jasper-Bekkers
Copy link
Collaborator

It would be nice to be able to opt in to them at least, maybe through a cfg

@MaikKlein
Copy link
Member Author

It would be nice to be able to opt in to them at least, maybe through a cfg

I mentioned this here #344 under feature flags

@MarijnS95
Copy link
Collaborator

This is coming up again when VK_AMDX_shader_enqueue was eagerly wrapped in #776, and is causing compatibility issues now that allowed breaking changes are made to the extension, because it's marked provisional: KhronosGroup/Vulkan-Docs#2442 (comment)

We should probably wrap the generated code as well as the relevant extension behind a feature flag or cfg flag, one that might allow us to make breaking changes to the code in nonbreaking releases or at the very least disable compiling these bits in i.e. Khronos CI.

This was referenced Oct 11, 2024
Open
Draft
This was referenced Nov 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ash: Hide provisional extensions behind new provisional feature flag ash-rs/ash
3 participants
@Jasper-Bekkers @MaikKlein @MarijnS95