Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing sz::string::shrink_to_fit #100

Closed
ashvardanian opened this issue Feb 21, 2024 · 3 comments
Closed

Missing sz::string::shrink_to_fit #100

ashvardanian opened this issue Feb 21, 2024 · 3 comments
Labels
cpp good first issue Good for newcomers released

Comments

@ashvardanian
Copy link
Owner

ashvardanian commented Feb 21, 2024 •
edited
Loading

The C layer defines the sz_string_shrink_to_fit, that is not covered by tests and is not yet used by the C++ API to implement the shrink_to_fit.
@ashvardanian ashvardanian added good first issue Good for newcomers cpp labels Feb 21, 2024
Repository owner deleted a comment from Majeed-GitHub Feb 28, 2024
@Riyazul555
Copy link
Contributor

Hey @ashvardanian can you please explain this issue a more

@ashvardanian
Copy link
Owner Author

@Riyazul555, at the second glance, this issue is trickier then I thought, as I don't yet have a sz_string_shrink_to_fit implementation even in the C layer. It may not be a good fit for a beginner, but if you are interested, cppreference.com describes the operation in more detail.

ashvardanian pushed a commit that referenced this issue Mar 18, 2024
@semantic-release-bot
Build: Released 3.7.0 [skip ci]
c2848c1 
# [3.7.0](v3.6.8...v3.7.0) (2024-03-18)

### Add

* `shrink_to_fit` ([c573a05](c573a05)), closes [#100](#100)

### Docs

* Debug builds need `-DCMAKE_BUILD_TYPE` ([45ea51c](45ea51c))

### Fix

* `try_replace` compilation error ([0a71676](0a71676))
* Self-assignment issues ([142f48a](142f48a))

### Make

* `dpkg` can't handle backslash ([89ea048](89ea048))
@ashvardanian
Copy link
Owner Author

🎉 This issue has been resolved in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cpp good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashvardanian @Riyazul555