Advice (and trades) repeat.

[kuzetsa]

As per #171 there is a bug involving repeated advice and trades, and not just MACD

It seems that there is undocumented behavior when the following code is called:

    if(this.trend.persisted && !this.trend.adviced) {
      this.trend.adviced = true;
      this.advice('long');
    } else
      this.advice();

Specifically, the lines with an empty call to this.advice(); seems to be the issue.

in my own fork / repo, I'll be pushing commits with a fix for these sorts of bugs.

At this time, it is unclear to me if @askmike is still accepting pull requests.

[kuzetsa]

Nevermind, I don't understand what the purpose of that code even was, and ultimately ended up forking the codebase after fixing the logic bug during a code audit & refactor.