-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging into Lighthouse #2
Comments
Love it 👍 I'm not sure we're getting any value by those particular Sentry captures at the moment anyway. |
roadmap: GoogleChrome/lighthouse#8956 (comment) It'll be named tracehouse. status: GoogleChrome/lighthouse#9230 currently under review |
Is this still the plan? |
@aslushnikov @paulirish @patrickhulce Looks like your did great work and finished few steps from the roadmap. Do you have any updates for this migration? Is this still the plan? |
Lighthouse team stopped short of bullet 3 in that roadmap (GoogleChrome/lighthouse#8956 (comment)). The patches were ported and the |
@patrickhulce Thank you. And many thanks to the It would be great to accomplish this migration. A lot of useful tools and users depend on it. |
Hello @patrickhulce |
Sorry for bothering you. I just have worried about this issue. Because |
Thanks for the poke @mbalabash! We decided how we're going to proceed (GoogleChrome/lighthouse#9519 (comment)) and it's just a matter of getting it done now. I'm moving more of my time back into lighthouse core this week, so I'd expect movement here by next week. Will keep you posted 👍 |
@patrickhulce Thank you! |
Hello, @patrickhulce Near month left since we last talked. Do you have any updates? |
I opened the first PRs in Lighthouse to make this happen but they are stagnating in review. I poked the reviewer yesterday, but I wouldn't get my hopes up for a swift turnaround. |
@patrickhulce Thank you for your time! |
It'd be nice to have Tracium integrated into Lighthouse repository.
Tracium mostly picks files from Lighthouse as-is.
The only changes I had to do are:
DEBUG
moduleThe only new code is the 10 lines in
//index.js
.@paulirish and @patrickhulce: WDYT?
The text was updated successfully, but these errors were encountered: