Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging into Lighthouse #2

Open
aslushnikov opened this issue Apr 25, 2019 · 13 comments
Open

Merging into Lighthouse #2

aslushnikov opened this issue Apr 25, 2019 · 13 comments

Comments

@aslushnikov
Copy link
Owner

It'd be nice to have Tracium integrated into Lighthouse repository.
Tracium mostly picks files from Lighthouse as-is.

The only changes I had to do are:

  • substitute logging with DEBUG module
  • strip away sentry

The only new code is the 10 lines in //index.js.

@paulirish and @patrickhulce: WDYT?

@patrickhulce
Copy link
Collaborator

Love it 👍 I'm not sure we're getting any value by those particular Sentry captures at the moment anyway.

@paulirish
Copy link
Collaborator

paulirish commented Jul 16, 2019

roadmap: GoogleChrome/lighthouse#8956 (comment)

It'll be named tracehouse.

status: GoogleChrome/lighthouse#9230 currently under review

@soulgalore
Copy link
Contributor

Is this still the plan?

@mbalabash
Copy link
Contributor

mbalabash commented Jun 2, 2020

@aslushnikov @paulirish @patrickhulce Looks like your did great work and finished few steps from the roadmap. Do you have any updates for this migration? Is this still the plan?

@patrickhulce
Copy link
Collaborator

Lighthouse team stopped short of bullet 3 in that roadmap (GoogleChrome/lighthouse#8956 (comment)). The patches were ported and the tracehouse folder within Lighthouse should work generically, but it's not easily consumable anywhere as we did not reach consensus as a team on how to organize subpackages. I'll raise this again at our next eng sync meeting.

@mbalabash
Copy link
Contributor

mbalabash commented Jun 2, 2020

@patrickhulce Thank you. And many thanks to the lighthouse team for their work.

It would be great to accomplish this migration. A lot of useful tools and users depend on it.
Few of them: size-limit, sitespeedio, estimo, size-limit-action, browsertime, etc.

@mbalabash
Copy link
Contributor

Hello @patrickhulce
Did you have a chance to discuss tracehouse issue with team? Do you have any updates?

@mbalabash
Copy link
Contributor

Sorry for bothering you. I just have worried about this issue. Because tracium doesn't work stable with the latest chrome versions (81, 82, 83).

@patrickhulce
Copy link
Collaborator

Thanks for the poke @mbalabash! We decided how we're going to proceed (GoogleChrome/lighthouse#9519 (comment)) and it's just a matter of getting it done now. I'm moving more of my time back into lighthouse core this week, so I'd expect movement here by next week.

Will keep you posted 👍

@mbalabash
Copy link
Contributor

@patrickhulce Thank you!

@mbalabash
Copy link
Contributor

Hello, @patrickhulce
I hope you're doing well.

Near month left since we last talked. Do you have any updates?

@patrickhulce
Copy link
Collaborator

I opened the first PRs in Lighthouse to make this happen but they are stagnating in review. I poked the reviewer yesterday, but I wouldn't get my hopes up for a swift turnaround.

@mbalabash
Copy link
Contributor

@patrickhulce Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants