From 4039cd41be163a5be40d529566a9d3280e0d6e18 Mon Sep 17 00:00:00 2001 From: Malte Poll <1780588+malt3@users.noreply.github.com> Date: Tue, 4 Jun 2024 16:35:47 +0200 Subject: [PATCH] always set 'use_default_shell_env' in ctx.actions.run Aspect uses shell wrappers that invoke tools like `dirname` and `uname`. When the default shell env is not inherited, this prevents tools from being found on systems without a working fallback $PATH (like NixOS). See also: NixOS/nixpkgs#289505 --- esbuild/private/esbuild.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/esbuild/private/esbuild.bzl b/esbuild/private/esbuild.bzl index 88c2c70..6485792 100644 --- a/esbuild/private/esbuild.bzl +++ b/esbuild/private/esbuild.bzl @@ -391,6 +391,7 @@ def _esbuild_impl(ctx): execution_requirements = execution_requirements, mnemonic = "esbuild", env = env, + use_default_shell_env = True, executable = launcher, )