Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Rust binaries don't build under --collect_code_coverage #497

Open
alexeagle opened this issue Jan 22, 2025 · 0 comments
Open

[Bug]: Rust binaries don't build under --collect_code_coverage #497

alexeagle opened this issue Jan 22, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@alexeagle
Copy link
Member

alexeagle commented Jan 22, 2025

This only affects users of pre-releases under bazel coverage.

What happened?

Context: https://github.com/aspect-build/rules_py/pull/492/files#r1925513752

We have issues with our sysroot not containing files needed to build our rust binaries with llvm and code coverage enabled. If a user is using a rules_py prerelease (and for our own development on a prerelease) they'll have to build the rust binaries under the same config as their bazel coverage command - but no one intended to instrument our rust code for coverage.

We should probably have a transition to explicitly turn off coverage instrumentation when we depend on our rust tools.

Version

1.1.0

How to reproduce

Any other information?

No response

@alexeagle alexeagle added the bug Something isn't working label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant