Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ts_config filters d.ts files from inputs #204

Closed
1 task
stoiky opened this issue Oct 31, 2022 · 0 comments · Fixed by #316
Closed
1 task

[Bug]: ts_config filters d.ts files from inputs #204

stoiky opened this issue Oct 31, 2022 · 0 comments · Fixed by #316
Assignees
Labels
bug Something isn't working

Comments

@stoiky
Copy link

stoiky commented Oct 31, 2022

What happened?

Some ts projects may have global.d.ts files in sources.
Currently they seem to not be included when writing the ts_config rule.
https://github.com/aspect-build/rules_ts/blob/main/ts/private/ts_config.bzl#L67

So this happens only when you use a dict() in tsconfig attribute.

Version

Development (host) and target OS/architectures: OSX

Output of bazel --version: 5.2.0

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: v1.0.0-rc4

Language(s) and/or frameworks involved: NA

How to reproduce

- create a global.d.ts file and have it used in inputs (eg https://www.typescriptlang.org/docs/handbook/declaration-files/templates/global-d-ts.html#global-library-template)
- create a ts_project rule and include all sources

Any other information?

Diff between generated tsconfig of rules_ts (above) and what tsc would use (below):
image

Fund our work

  • Sponsor our open source work by donating a bug bounty
@stoiky stoiky added the bug Something isn't working label Oct 31, 2022
@gregmagolan gregmagolan moved this to 🔖 Ready in Open Source Feb 5, 2023
@gregmagolan gregmagolan moved this from 🔖 Ready to 🏗 In progress in Open Source Feb 11, 2023
@gregmagolan gregmagolan self-assigned this Feb 11, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Open Source Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants