Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ts_config doesn't provide a JsInfo #271

Closed
gregmagolan opened this issue Dec 9, 2022 · 6 comments · Fixed by #315
Closed

[Bug]: ts_config doesn't provide a JsInfo #271

gregmagolan opened this issue Dec 9, 2022 · 6 comments · Fixed by #315
Labels
bug Something isn't working

Comments

@gregmagolan
Copy link
Member

See https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1670621678898069?thread_ts=1670620951.407769&cid=CEZUUKQ6P for more context
@gregmagolan
Copy link
Member Author

Transitive npm deps from the tsconfig attribute in ts_project should not get forwarded to downstream consumers via the JsInfo it provides or via runfiles.

@Toxaris
Copy link

Toxaris commented Dec 11, 2022

I put together a repro in https://github.com/Toxaris/ts_config_deps_repro.

@Toxaris
Copy link

Toxaris commented Dec 12, 2022 •
edited
Loading

We figured out in Slack that disabling workers helps. I updated the https://github.com/Toxaris/ts_config_deps_repro to also demonstrate this work around.

@gregmagolan
Copy link
Member Author

Gotcha. That is quite possible as there seem to be a few more gremlins in worker mode.
cc @thesayyn

@gregmagolan gregmagolan added the bug Something isn't working label Feb 6, 2023
@gregmagolan gregmagolan moved this to 📋 Backlog in Open Source Feb 6, 2023
@gregmagolan gregmagolan moved this from 📋 Backlog to 🔖 Ready in Open Source Feb 6, 2023
@gregmagolan
Copy link
Member Author

@Toxaris The latest release of rules_ts has a big refactor for worker mode. When you have a chance could you please try turning working mode back on in your repro?

@gregmagolan gregmagolan mentioned this issue Feb 11, 2023
Merged
@gregmagolan gregmagolan moved this from 🔖 Ready to 🏗 In progress in Open Source Feb 11, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Open Source Feb 11, 2023
@gregmagolan
Copy link
Member Author

Fix will be included in v1.13.0 which I'm going to cut right after #316 lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add JsInfo provider to ts_config rule aspect-build/rules_ts
2 participants
@gregmagolan @Toxaris