Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Support proto_library in other packages for ts_proto_library #752

Open
ryanli opened this issue Dec 19, 2024 · 0 comments
Open

[FR]: Support proto_library in other packages for ts_proto_library #752

ryanli opened this issue Dec 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ryanli
Copy link

ryanli commented Dec 19, 2024

What is the current behavior?

Right now ts_proto_library only supports using depending on proto_library in the same package as it requires proto_srcs to be set, which takes file names as opposed to target names. This makes it impossible to include dependencies. See #627 for an example.

Describe the feature

ts_proto_library should be able to depend on protobuf messages and proto_library rules defined in other packages, and copy_files should copy them to the right place.

@ryanli ryanli added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant