Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tsconfig composite handling to ts_config #762

Open
jbedard opened this issue Jan 10, 2025 · 0 comments
Open

move tsconfig composite handling to ts_config #762

jbedard opened this issue Jan 10, 2025 · 0 comments
Assignees
Labels
breaking Breaking change the will likely require a major release

Comments

@jbedard
Copy link
Member

jbedard commented Jan 10, 2025

Today ts_project adds additional dependencies when the tsconfig composite flag is used. These deps should be required within the ts_project(tsconfig) value, most likely from creating a ts_config with the appropriate deps.

This should resolve confusion with ts_project behaving different depending on a tsconfig.json property. This should avoid issues such as #757

@jbedard jbedard added the breaking Breaking change the will likely require a major release label Jan 10, 2025
@jbedard jbedard self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change the will likely require a major release
Projects
None yet
Development

No branches or pull requests

1 participant