Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Update version of Microsoft.ApplicationInsights.AspNetCore #20

Closed
JunTaoLuo opened this issue Apr 5, 2017 · 11 comments
Closed

Update version of Microsoft.ApplicationInsights.AspNetCore #20

JunTaoLuo opened this issue Apr 5, 2017 · 11 comments
Assignees

Comments

@JunTaoLuo
Copy link
Contributor

This dependency depends on Hosing 1.0.0, we will need to update to a new version that targets our 2.0.0 packages.

@glennc
Copy link
Member

glennc commented Apr 27, 2017

AppInsights feed https://www.myget.org/F/applicationinsights/api/v3/index.json

There is a 2.1.0-beta2 available there now. @JunTaoLuo @muratg Presumably we need to get this ingested now if it goes in the store.

@Eilon
Copy link
Member

Eilon commented Apr 27, 2017

@kichalla - is this something we can mirror in our mirror task? I don't want to add a dependency on another team's MyGet feed from within this repo.

@kichalla
Copy link
Member

Yes we can add it.

@kichalla
Copy link
Member

It's part of the mirror now. So we can probably close this issue.

@Eilon
Copy link
Member

Eilon commented Apr 27, 2017

It's worth noting that the original thing @JunTaoLuo mentioned is this:

This dependency depends on Hosing 1.0.0, we will need to update to a new version that targets our 2.0.0 packages.

And this new mirroring doesn't fix that. However, that's ok - we don't need AppInsights to update their Hosting dependency.

But, to close this issue, we need to actually update the code in this repo to use the new AppInsights packages.

@Eilon
Copy link
Member

Eilon commented Apr 27, 2017

Assigning to @pakrym for Preview1.

@DamianEdwards
Copy link
Member

Do we have a plan in place to ingest updates?

@Eilon
Copy link
Member

Eilon commented Apr 27, 2017

And actually, even after taking that new dependency, let's keep this bug open, because we need to wait for the final build of App Insights RTM as well for Preview 1.

@DamianEdwards
Copy link
Member

snap

@DamianEdwards
Copy link
Member

FYI there is an issue with the 2.1.0-beta2 package: microsoft/ApplicationInsights-aspnetcore#416

@pakrym
Copy link
Contributor

pakrym commented May 8, 2017

Fixed by #46

@pakrym pakrym closed this as completed May 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants