Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Remove PreferHostingUrls from WebHostOptions and read the value from config during EnsureServer() #1045

Closed
JunTaoLuo opened this issue Apr 25, 2017 · 0 comments
Assignees

Comments

@JunTaoLuo
Copy link
Contributor

Related to aspnet/IISIntegration#361.

The issue here is that the options are created before configure services and hosting startup assemblies. Now that UseIISIntegration is planned to be called from the hosting startup assembly, this means that the options will be out of date when we read from it in EnsureServer(). The config is always up to date so we should use that to set the PreferHostingUrls property on the IServerAddressesFeature instead. This is currently what we do for server urls due to the same reason and it works.

cc @Tratcher

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant