Consider changing WebApplication* to WebHost*

[davidfowl]

We have IWebApplicationBuilder, WebApplicationBuilder, IWebApplication, and IApplicationBuilder.

IApplicationBuilder looks related to IWebApplicationBuilder but they are not.

Today:

var app = new WebApplicationBuilder()
                        .UseServer("Microsoft.AspNet.Server.Kestrel")
                        .UseUrls("http://localhost:5001")
                        .UseStartup<Startup>()
                        .Build();

app.Run();

Potentially changed to:

var host = new WebHostBuilder()
                        .UseServer("Microsoft.AspNet.Server.Kestrel")
                        .UseUrls("http://localhost:5001")
                        .UseStartup<Startup>()
                        .Build();

host.Run();

IWebHostBuilder builds the IWebHost

/cc @lodejard @Tratcher @JunTaoLuo @DamianEdwards Thoughts? I'm not 100% on the naming though and I also don't think this matters that much but think about it a little 😄

This is the hosting repository and we are hosting ASP.NET so it sorta makes sense.

[Tratcher]

I do agree there's ambiguity between IWebApplicationBuilder and IApplicationBuilder.

[davidfowl]

Shall we go with host instead of application then?

[Tratcher]

You're with @DamianEdwards right? Did he have anything to say on the subject?

I think host is fine, but I don't envy @JunTaoLuo having to touch all the repos again.

[davidfowl]

Yes, we spoke about this today and concluded that it looks like WebApplication was wrong.

[mikes-gh]

Would that mean also changing WebApplicationConfiguration to WebHostConfiguration?

Personally I prefer WebHosting prefix but WebHost is also fine.

[davidfowl]

@mikes-gh yes re: WebHostConfiguration

[mikes-gh]

@davidfowl

WebHostBuilder
WebHostConfiguration

vs

WebHostingBuilder
WebHostingConfiguration

The later seems slightly more abstracted to me

[davidfowl]

I dunno what you mean by more abstracted. I prefer:

I prefer a WebHostBuilder that builds a WebHost using WebHostConfiguration

[mikes-gh]

WebHost is fine.

[davidfowl]

PS: @JunTaoLuo I'm sorry dude, that's a lot of repos to update 😞

[mikes-gh]

WebHostConfiguration would read hosting.json seems a mismatch
WebHostingConfiguration would seem a more logically. match..

[davidfowl]

But we're going to call it WebHostConfiguration so it matches the other names. We're splitting hairs and naming is hard but that's what we're calling it.

[aL3891]

Maybe hosting.json could be host.json? (or webhost.json)

[henkmollema]

hosting.json configures the hosting API. Webhost is just a part of that. It's not like we're renaming the repo to Webhost.

[JunTaoLuo]

Marking as done since rename has been merged to dev and all repos have been updated. Will post announcement after monitoring test pass and close issue.

[guardrex]

@JunTaoLuo Suggestion: Due to the slight lag in MyGet, you might want to say it will be for (if I have this correct, of course) ...

Microsoft.AspNet.Hosting rc2-16219 and later. Microsoft.AspNet.IISIntegration rc2-16132 and later

... according to @Tratcher aspnet/IISIntegration#52 (comment)

[mikes-gh]

@JunTaoLuo
Looks like aspnet/Security is failing after this

[davidfowl]

What is failing?

[mikes-gh]

Microsoft.AspNet.Authentication.Test

I noticed because I have a pull request for FacebookMiddleware

[00:05:14] Compiling 
[00:05:14] Microsoft.AspNet.Authentication.Test
[00:05:14]  for 
[00:05:14] DNX,Version=v4.5.1
[00:05:14] 
[00:05:17] �[1m�[31mC:\projects\security\test\Microsoft.AspNet.Authentication.Test\test\Microsoft.AspNet.Authentication.Test\Twitter\TwitterMiddlewareTests.cs(155,31): error CS0246: The type or namespace name 'WebHostBuilder' could not be found (are you missing a usi
[00:05:17] ng directive or an assembly reference?)
[00:05:17] 
[00:05:17] 
[00:05:17] Compilation failed.

[JunTaoLuo]

@mikes-gh I think your packages may be out of date and updating to the newest packages should fix the problem. @guardrex I don't know how feasible listing all the versions is since many packages were affected. I will look into it but at least the renames will impact Microsoft.AspNet.Hosting rc2-16237 or later for sure.

[JunTaoLuo]

Seems like test pass will be broken for other reasons. Since I did not see any test failures relating to this change, I'm closing the issue for now.

[davidfowl]

👏