This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 307
Move some WebHostBuilderExtensions to Hosting.Abstractions #675
Comments
Why not move everything that can be moved? |
Doesn't matter, as long as it doesn't require too much implementation code or any dependencies. |
I'm confused. Why webroot is not the configuration that comes with StaticFiles? It looks to me that only the StaticFile module is interested in setting the dir where it would find files to serve. |
StaticFiles and MVC use the webroot folder by default for serving files. It's in hosting because it flows via the |
Thanks, @davidfowl, when does MVC need webroot folder to serve files? I'm under the impression this should be done by StaticFiles. |
Oh I see. It's in the core. Thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
IISIntegration was able to depend just on Hosting.Abstractions until it called CaptureStartupErrors.
Move extensions that may be used by extensions from other packages and not just app code. E.g:
Don't move:
https://github.com/aspnet/Hosting/blob/dev/src/Microsoft.AspNetCore.Hosting/WebHostBuilderExtensions.cs
@JunTaoLuo @davidfowl
The text was updated successfully, but these errors were encountered: