Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Issue with Microsoft.AspNetCore.Server.Testing IISDeployer on net451 #684

Closed
DavidObando opened this issue Mar 31, 2016 · 4 comments
Closed
Assignees
Milestone

Comments

@DavidObando
Copy link
Member

In ApplicationDeployerFactory.cs we're ifdeffing on DNX451 but not on NET451. Is this by design? Is there a reason we can't include NET451 too?

It's currently making a couple of tests in the Performance repository to fail with message:

    Startup [Variation: StarterMvc_IISScenario] [Stage: Collection] [Iteration: 1/1] [FAIL]
      System.NotSupportedException : Found no deployers suitable for server type 'IIS' with the current runtime.
      Stack Trace:
           at Microsoft.AspNetCore.Server.Testing.ApplicationDeployerFactory.Create(DeploymentParameters deploymentParameters, ILogger logger)
        D:\GitHub\aspnet\Performance\src\Benchmarks.Utility\Helpers\IISTestManager.cs(51,0): at Benchmarks.Utility.Helpers.IISTestManager.Initialize(ILoggerFactory loggerFactory)
        D:\GitHub\aspnet\Performance\test\Microsoft.AspNetCore.Tests.Performance\WebIISPerformance.cs(30,0): at Microsoft.AspNetCore.Tests.Performance.WebIISPerformance..ctor(IISTestManager testManager)

If this is a DNX451 scenario only I'll disable these tests on non-DNX451 runtimes.

@Tratcher
Copy link
Member

FYI we're not using the IIS Deployer in any of our automated tests because it requires running as admin. As such it hasn't been actively maintained and may have regressed due to recent framework churn.

@Tratcher Tratcher added the bug label Mar 31, 2016
@Tratcher Tratcher added this to the 1.0.0-rc2 milestone Mar 31, 2016
@davidfowl
Copy link
Member

So yes it's a bug and should be net451 instead of dnx451. The ifdef wasn't updated

@JunTaoLuo
Copy link
Contributor

I think we can also remove DNX451 from https://github.com/aspnet/Hosting/find/dev#L60 as well

@BrennanConroy
Copy link
Member

b5816f2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants