Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

Move tsconfig.json files to template root folders #346

Closed
SteveSandersonMS opened this issue Sep 30, 2016 · 2 comments
Closed

Move tsconfig.json files to template root folders #346

SteveSandersonMS opened this issue Sep 30, 2016 · 2 comments
Labels
up-for-grabs

Comments

@SteveSandersonMS
Copy link
Member

As per comments in #257, having the tsconfig.json files at non-root locations causes issues in TypeScript 2.0. Or at least people say so (I haven't hit any such issues myself) - it would be great to know for sure what the repro steps are.

If there really is a reliably reproducible problem with tsconfig.json in non-project-root locations, we'll need to move it back to project root.

Note: supposedly this is fixed in TS 2.1 anyway, but we can't really wait for that.
@MarkPieszak
Copy link
Contributor

I can take care of this one inside the TS2 upgrade PR #258 if you'd like @SteveSandersonMS

@SteveSandersonMS
Copy link
Member Author

Don't worry - it was super trivial, so I just did it :)

@snyk-bot snyk-bot mentioned this issue Sep 4, 2021
Open
@harunpehlivan harunpehlivan mentioned this issue Jun 30, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 26, 2022
Open
@harunpehlivan harunpehlivan mentioned this issue Dec 26, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SteveSandersonMS @MarkPieszak