You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.
Actual behavior: It references the package "successfully" but silently fails to bring in any types.
We have a build\PublishWithAspNetCoreTargetManifest.targets file, which means NuGet thinks the package is supported by all frameworks (with a special targets file for netcoreapp2.0). We should put that file in build\netcoreapp2.0 so NuGet will see that there are no assets for any other framework.
Also, we need to verify that NuGet does actually disallow installing it in that circumstance. It's possible it won't disallow it, just won't reference the targets files. In that case, we could put a fallback targets file with an error message.
The text was updated successfully, but these errors were encountered:
/cc @muratg - We can probably wait until preview 3 for this, but we really need to make sure this package can't be installed into non-netcoreapp2.0 projects.
Seems like simply moving the targets file to netcoreapp2.0 does not prevent the package from being referenced from an app targeting net461. We will likely need to add a default target that gives an error of some kind.
Repro Steps:
net461
Microsoft.AspNetCore.All
Expected behavior: Error of some kind
Actual behavior: It references the package "successfully" but silently fails to bring in any types.
We have a
build\PublishWithAspNetCoreTargetManifest.targets
file, which means NuGet thinks the package is supported by all frameworks (with a special targets file fornetcoreapp2.0
). We should put that file inbuild\netcoreapp2.0
so NuGet will see that there are no assets for any other framework.Also, we need to verify that NuGet does actually disallow installing it in that circumstance. It's possible it won't disallow it, just won't reference the targets files. In that case, we could put a fallback targets file with an error message.
The text was updated successfully, but these errors were encountered: