diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultDisplayTemplatesTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultDisplayTemplatesTest.cs index e082145386..95c4d98c04 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultDisplayTemplatesTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultDisplayTemplatesTest.cs @@ -25,21 +25,21 @@ public static TheoryData HtmlEncodeData return new TheoryData { { "Simple Display Text", false, "Simple Display Text" }, - { "Simple Display Text", true, "Simple Display Text" }, + { "Simple Display Text", true, "HtmlEncode[[Simple Display Text]]" }, { "text", false, "text" }, - { "text", true, "<blink>text</blink>" }, + { "text", true, "HtmlEncode[[text]]" }, { "&'\"", false, "&'\"" }, - { "&'\"", true, "&'"" }, + { "&'\"", true, "HtmlEncode[[&'\"]]" }, { " ¡ÿĀ", false, " ¡ÿĀ" }, // high ASCII - { " ¡ÿĀ", true, " ¡ÿĀ" }, + { " ¡ÿĀ", true, "HtmlEncode[[ ¡ÿĀ]]" }, { "Chinese西雅图Chars", false, "Chinese西雅图Chars" }, - { "Chinese西雅图Chars", true, "Chinese西雅图Chars" }, + { "Chinese西雅图Chars", true, "HtmlEncode[[Chinese西雅图Chars]]" }, { "Unicode؃Format؃Char", false, "Unicode؃Format؃Char" }, // class Cf - { "Unicode؃Format؃Char", true, "Unicode؃Format؃Char" }, + { "Unicode؃Format؃Char", true, "HtmlEncode[[Unicode؃Format؃Char]]" }, { "UnicodeῼTitlecaseῼChar", false, "UnicodeῼTitlecaseῼChar" }, // class Lt - { "UnicodeῼTitlecaseῼChar", true, "UnicodeῼTitlecaseῼChar" }, + { "UnicodeῼTitlecaseῼChar", true, "HtmlEncode[[UnicodeῼTitlecaseῼChar]]" }, { "UnicodeःCombiningःChar", false, "UnicodeःCombiningःChar" }, // class Mc - { "UnicodeःCombiningःChar", true, "UnicodeःCombiningःChar" }, + { "UnicodeःCombiningःChar", true, "HtmlEncode[[UnicodeःCombiningःChar]]" }, }; } } @@ -48,11 +48,11 @@ public static TheoryData HtmlEncodeData public void ObjectTemplateDisplaysSimplePropertiesOnObjectByDefault() { var expected = - "
Property1
" + Environment.NewLine - + "
Model = p1, ModelType = System.String, PropertyName = Property1," + + "
HtmlEncode[[Property1]]
" + Environment.NewLine + + "
Model = p1, ModelType = System.String, PropertyName = Property1," + " SimpleDisplayText = p1
" + Environment.NewLine - + "
Property2
" + Environment.NewLine - + "
Model = (null), ModelType = System.String, PropertyName = Property2," + + + "
HtmlEncode[[Property2]]
" + Environment.NewLine + + "
Model = (null), ModelType = System.String, PropertyName = Property2," + " SimpleDisplayText = (null)
" + Environment.NewLine; // Arrange @@ -120,10 +120,10 @@ public void ObjectTemplate_IgnoresPropertiesWith_ScaffoldColumnFalse() { // Arrange var expected = -@"
Property1
-
-
Property3
-
+@"
HtmlEncode[[Property1]]
+
HtmlEncode[[]]
+
HtmlEncode[[Property3]]
+
HtmlEncode[[]]
"; var model = new DefaultTemplatesUtilities.ObjectWithScaffoldColumn(); var viewEngine = new Mock(); @@ -144,8 +144,8 @@ public void ObjectTemplate_HonoursHideSurroundingHtml() // Arrange var expected = "Model = p1, ModelType = System.String, PropertyName = Property1, SimpleDisplayText = p1" + - "
Property2
" + Environment.NewLine + - "
Model = (null), ModelType = System.String, PropertyName = Property2," + + "
HtmlEncode[[Property2]]
" + Environment.NewLine + + "
Model = (null), ModelType = System.String, PropertyName = Property2," + " SimpleDisplayText = (null)
" + Environment.NewLine; var model = new DefaultTemplatesUtilities.ObjectTemplateModel { Property1 = "p1", Property2 = null }; @@ -187,13 +187,13 @@ public void ObjectTemplate_OrdersProperties_AsExpected() { var label = string.Format( CultureInfo.InvariantCulture, - "
{0}
", + "
HtmlEncode[[{0}]]
", property); stringBuilder.AppendLine(label); var value = string.Format( CultureInfo.InvariantCulture, - "
Model = (null), ModelType = System.String, PropertyName = {0}, " + + "
Model = (null), ModelType = System.String, PropertyName = {0}, " + "SimpleDisplayText = (null)
", property); stringBuilder.AppendLine(value); @@ -223,7 +223,7 @@ public void HiddenInputTemplate_ReturnsValue() var result = DefaultDisplayTemplates.HiddenInputTemplate(html); // Assert - Assert.Equal("Formatted string", result); + Assert.Equal("HtmlEncode[[Formatted string]]", result); } [Fact] @@ -268,7 +268,7 @@ public void Display_FindsViewDataMember() var result = helper.Display("Property1"); // Assert - Assert.Equal("ViewData string", result.ToString()); + Assert.Equal("HtmlEncode[[ViewData string]]", result.ToString()); } [Fact] @@ -287,7 +287,7 @@ public void DisplayFor_FindsModel() var result = helper.DisplayFor(m => m.Property1); // Assert - Assert.Equal("Model string", result.ToString()); + Assert.Equal("HtmlEncode[[Model string]]", result.ToString()); } [Fact] @@ -305,7 +305,7 @@ public void Display_FindsModel_IfNoViewDataMember() var result = helper.Display("Property1"); // Assert - Assert.Equal("Model string", result.ToString()); + Assert.Equal("HtmlEncode[[Model string]]", result.ToString()); } [Theory] @@ -326,7 +326,7 @@ public void DisplayFor_FindsModel_EvenIfNullOrEmpty(string propertyValue) var result = helper.DisplayFor(m => m.Property1); // Assert - Assert.Empty(result.ToString()); + Assert.Equal("HtmlEncode[[]]", result.ToString()); } [Fact] diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultEditorTemplatesTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultEditorTemplatesTest.cs index 0cd34ab7a0..40bb20fa5a 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultEditorTemplatesTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultEditorTemplatesTest.cs @@ -34,8 +34,8 @@ public static TheoryData TemplateNameData { string.Empty, "__TextBox__ class='text-box single-line'" }, { "EmailAddress", "__TextBox__ class='text-box single-line' type='email'" }, { "emailaddress", "__TextBox__ class='text-box single-line' type='email'" }, - { "HiddenInput", "True__Hidden__" }, // Hidden also generates value by default. - { "HIDDENINPUT", "True__Hidden__" }, + { "HiddenInput", "HtmlEncode[[True]]__Hidden__" }, // Hidden also generates value by default. + { "HIDDENINPUT", "HtmlEncode[[True]]__Hidden__" }, { "MultilineText", "__TextArea__ class='text-box multi-line'" }, { "multilinetext", "__TextArea__ class='text-box multi-line'" }, { "Password", "__Password__ class='text-box single-line password'" }, @@ -91,15 +91,15 @@ public static TheoryData TemplateNameData public void ObjectTemplateEditsSimplePropertiesOnObjectByDefault() { var expected = - "
" + Environment.NewLine - + "
Model = p1, ModelType = System.String, PropertyName = Property1," + + "
" + Environment.NewLine + + "
Model = p1, ModelType = System.String, PropertyName = Property1," + " SimpleDisplayText = p1 " + - "" + + "" + "
" + Environment.NewLine - + "
" + Environment.NewLine - + "
Model = (null), ModelType = System.String, PropertyName = Property2," + + + "
" + Environment.NewLine + + "
Model = (null), ModelType = System.String, PropertyName = Property2," + " SimpleDisplayText = (null) " + - "" + + "" + "
" + Environment.NewLine; // Arrange @@ -174,15 +174,15 @@ public void ObjectTemplate_IgnoresPropertiesWith_ScaffoldColumnFalse() { // Arrange var expected = -@"
" + +@"
" + Environment.NewLine + -@"
" + -@"
" + +@"
" + +@"
" + Environment.NewLine + -@"
" + +@"
" + Environment.NewLine + -@"
" + -@"
" + +@"
" + +@"
" + Environment.NewLine; var model = new DefaultTemplatesUtilities.ObjectWithScaffoldColumn(); @@ -204,11 +204,11 @@ public void ObjectTemplate_HonoursHideSurroundingHtml() // Arrange var expected = "Model = p1, ModelType = System.String, PropertyName = Property1, SimpleDisplayText = p1" + - "
" + + "
" + Environment.NewLine + - "
" + + "
" + "Model = (null), ModelType = System.String, PropertyName = Property2, SimpleDisplayText = (null) " + - "" + + "" + "
" + Environment.NewLine; @@ -250,15 +250,15 @@ public void ObjectTemplate_OrdersProperties_AsExpected() { var label = string.Format( CultureInfo.InvariantCulture, - "
", + "
", property); stringBuilder.AppendLine(label); var value = string.Format( CultureInfo.InvariantCulture, - "
Model = (null), ModelType = System.String, PropertyName = {0}, " + + "
Model = (null), ModelType = System.String, PropertyName = {0}, " + "SimpleDisplayText = (null) " + - "" + + "" + "
", property); stringBuilder.AppendLine(value); @@ -277,7 +277,7 @@ public void HiddenInputTemplate_ReturnsValueAndHiddenInput() { // Arrange var expected = - "Formatted string"; + "HtmlEncode[[Formatted string]]"; var model = "Model string"; var html = DefaultTemplatesUtilities.GetHtmlHelper(model); @@ -298,7 +298,7 @@ public void HiddenInputTemplate_ReturnsValueAndHiddenInput() public void HiddenInputTemplate_HonoursHideSurroundingHtml() { // Arrange - var expected = ""; + var expected = ""; var model = "Model string"; @@ -326,9 +326,9 @@ public void MultilineTextTemplate_ReturnsTextArea() { // Arrange var expected = - ""; + "HtmlEncode[[Formatted string]]"; var model = "Model string"; var html = DefaultTemplatesUtilities.GetHtmlHelper(model); @@ -575,22 +575,22 @@ public void Editor_FindsViewDataMember() // Assert Assert.Equal( - "", + "", result.ToString()); } // DateTime-local is not special-cased unless using Html5DateRenderingMode.Rfc3339. [Theory] [InlineData("date", "{0:d}", "02/01/2000")] - [InlineData("datetime", null, "02/01/2000 03:04:05 +00:00")] - [InlineData("datetime-local", null, "02/01/2000 03:04:05 +00:00")] + [InlineData("datetime", null, "02/01/2000 03:04:05 +00:00")] + [InlineData("datetime-local", null, "02/01/2000 03:04:05 +00:00")] [InlineData("time", "{0:t}", "03:04")] [ReplaceCulture] public void Editor_FindsCorrectDateOrTimeTemplate(string dataTypeName, string editFormatString, string expected) { // Arrange - var expectedInput = ""; + var expectedInput = ""; var offset = TimeSpan.FromHours(0); var model = new DateTimeOffset( year: 2000, @@ -629,15 +629,15 @@ public void Editor_FindsCorrectDateOrTimeTemplate(string dataTypeName, string ed [Theory] [InlineData("date", "{0:d}", "2000-01-02")] - [InlineData("datetime", null, "2000-01-02T03:04:05.060+00:00")] + [InlineData("datetime", null, "2000-01-02T03:04:05.060+00:00")] [InlineData("datetime-local", null, "2000-01-02T03:04:05.060")] [InlineData("time", "{0:t}", "03:04:05.060")] [ReplaceCulture] public void Editor_AppliesRfc3339(string dataTypeName, string editFormatString, string expected) { // Arrange - var expectedInput = ""; + var expectedInput = ""; // Place DateTime-local value in current timezone. var offset = string.Equals("", dataTypeName) ? DateTimeOffset.Now.Offset : TimeSpan.FromHours(0); @@ -689,8 +689,8 @@ public void Editor_AppliesRfc3339(string dataTypeName, string editFormatString, public void Editor_AppliesNonDefaultEditFormat(string dataTypeName, Html5DateRenderingMode renderingMode) { // Arrange - var expectedInput = ""; + var expectedInput = ""; var offset = TimeSpan.FromHours(0); var model = new DateTimeOffset( year: 2000, @@ -748,7 +748,7 @@ public void EditorFor_FindsModel() // Assert Assert.Equal( - "", + "", result.ToString()); } @@ -768,7 +768,7 @@ public void Editor_FindsModel_IfNoViewDataMember() // Assert Assert.Equal( - "", + "", result.ToString()); } @@ -791,7 +791,7 @@ public void EditorFor_FindsModel_EvenIfNullOrEmpty(string propertyValue) // Assert Assert.Equal( - "", + "", result.ToString()); } diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultTemplatesUtilities.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultTemplatesUtilities.cs index 8951228d3e..d34a588553 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultTemplatesUtilities.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/DefaultTemplatesUtilities.cs @@ -14,6 +14,7 @@ using Microsoft.AspNet.Routing; using Microsoft.Framework.OptionsModel; using Microsoft.Framework.WebEncoders; +using Microsoft.Framework.WebEncoders.Testing; using Moq; namespace Microsoft.AspNet.Mvc.Rendering @@ -193,7 +194,7 @@ private static HtmlHelper GetHtmlHelper( optionsAccessor.Object, provider, urlHelper, - new HtmlEncoder()); + new CommonTestEncoder()); } // TemplateRenderer will Contextualize this transient service. @@ -201,7 +202,7 @@ private static HtmlHelper GetHtmlHelper( htmlGenerator, viewEngine, provider, - new HtmlEncoder(), + new CommonTestEncoder(), new UrlEncoder(), new JavaScriptStringEncoder()); if (innerHelperWrapper != null) @@ -216,7 +217,7 @@ private static HtmlHelper GetHtmlHelper( htmlGenerator, viewEngine, provider, - new HtmlEncoder(), + new CommonTestEncoder(), new UrlEncoder(), new JavaScriptStringEncoder()); var viewContext = new ViewContext(actionContext, Mock.Of(), viewData, null, new StringWriter()); @@ -267,7 +268,7 @@ private static AntiForgery GetAntiForgeryInstance() dataProtectionProvider.Object, additionalDataProvider.Object, optionsAccessor.Object, - new HtmlEncoder(), + new CommonTestEncoder(), mockDataProtectionOptions.Object); } diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperCheckboxTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperCheckboxTest.cs index 4fb53da03b..77344d7245 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperCheckboxTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperCheckboxTest.cs @@ -17,8 +17,8 @@ public class HtmlHelperCheckBoxTest public void CheckBoxOverridesCalculatedValuesWithValuesFromHtmlAttributes() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); // Act @@ -34,8 +34,8 @@ public void CheckBoxOverridesCalculatedValuesWithValuesFromHtmlAttributes() public void CheckBoxExplicitParametersOverrideDictionary_ForValueInModel() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); // Act @@ -51,8 +51,8 @@ public void CheckBoxExplicitParametersOverrideDictionary_ForValueInModel() public void CheckBoxExplicitParametersOverrideDictionary_ForNullModel() { // Arrange - var expected = @"" + - @""; + var expected = @"" + + @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(); // Act @@ -81,8 +81,8 @@ public void CheckBoxWithInvalidBooleanThrows() public void CheckBoxCheckedWithOnlyName() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); // Act @@ -96,8 +96,8 @@ public void CheckBoxCheckedWithOnlyName() public void CheckBoxUsesAttemptedValueFromModelState() { // Arrange - var expected = @"" + - @""; + var expected = @"" + + @""; var valueProviderResult = new ValueProviderResult("false", "false", CultureInfo.InvariantCulture); var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); helper.ViewData.ModelState.SetModelValue("Property1", valueProviderResult); @@ -113,9 +113,9 @@ public void CheckBoxUsesAttemptedValueFromModelState() public void CheckBoxGeneratesUnobtrusiveValidationAttributes() { // Arrange - var expected = @"" + - @""; + var expected = @"" + + @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetModelWithValidationViewData()); // Act @@ -129,9 +129,9 @@ public void CheckBoxGeneratesUnobtrusiveValidationAttributes() public void CheckBoxReplacesUnderscoresInHtmlAttributesWithDashes() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); var htmlAttributes = new { Property1_Property3 = "Property3ObjValue" }; @@ -146,9 +146,9 @@ public void CheckBoxReplacesUnderscoresInHtmlAttributesWithDashes() public void CheckBoxWithPrefix_ReplaceDotsInIdByDefaultWithUnderscores() { // Arrange - var expected = @""; + var expected = @""; var dictionary = new RouteValueDictionary(new { Property3 = "Property3Value" }); var helper = DefaultTemplatesUtilities.GetHtmlHelper(); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; @@ -164,9 +164,9 @@ public void CheckBoxWithPrefix_ReplaceDotsInIdByDefaultWithUnderscores() public void CheckBoxWithPrefix_ReplacesDotsInIdWithIdDotReplacement() { // Arrange - var expected = @""; + var expected = @""; var dictionary = new Dictionary { { "Property3", "Property3Value" } }; var helper = DefaultTemplatesUtilities.GetHtmlHelper(); helper.IdAttributeDotReplacement = "!!!"; @@ -183,9 +183,9 @@ public void CheckBoxWithPrefix_ReplacesDotsInIdWithIdDotReplacement() public void CheckBoxWithPrefixAndEmptyName() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(model: false); var attributes = new Dictionary { { "Property3", "Property3Value" } }; helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; @@ -201,9 +201,9 @@ public void CheckBoxWithPrefixAndEmptyName() public void CheckBoxWithComplexExpressionsEvaluatesValuesInViewDataDictionary() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetModelWithValidationViewData()); // Act @@ -217,8 +217,8 @@ public void CheckBoxWithComplexExpressionsEvaluatesValuesInViewDataDictionary() public void CheckBoxForWithNullContainer_TreatsBooleanAsFalse() { // Arrange - var expected = @"" + - @""; + var expected = @"" + + @""; var viewData = GetTestModelViewData(); var helper = DefaultTemplatesUtilities.GetHtmlHelper(viewData); var valueProviderResult = new ValueProviderResult("false", "false", CultureInfo.InvariantCulture); @@ -233,12 +233,12 @@ public void CheckBoxForWithNullContainer_TreatsBooleanAsFalse() [Theory] [InlineData(false, "")] - [InlineData(true, "checked=\"checked\" ")] + [InlineData(true, "checked=\"HtmlEncode[[checked]]\" ")] public void CheckBoxForWithNonNullContainer_UsesPropertyValue(bool value, string expectedChecked) { // Arrange - var expected = @"" + - @""; + var expected = @"" + + @""; expected = string.Format(expected, expectedChecked); var viewData = GetTestModelViewData(); @@ -260,8 +260,8 @@ public void CheckBoxForWithNonNullContainer_UsesPropertyValue(bool value, string public void CheckBoxForOverridesCalculatedParametersWithValuesFromHtmlAttributes() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); // Act @@ -275,9 +275,9 @@ public void CheckBoxForOverridesCalculatedParametersWithValuesFromHtmlAttributes public void CheckBoxForGeneratesUnobtrusiveValidationAttributes() { // Arrange - var expected = @"" + - @""; + var expected = @"" + + @""; var metadataProvider = TestModelMetadataProvider.CreateDefaultProvider(); var viewDataDictionary = new ViewDataDictionary(metadataProvider) { @@ -294,12 +294,12 @@ public void CheckBoxForGeneratesUnobtrusiveValidationAttributes() [Theory] [InlineData("false", "")] - [InlineData("true", "checked=\"checked\" ")] + [InlineData("true", "checked=\"HtmlEncode[[checked]]\" ")] public void CheckBoxFor_UsesModelStateAttemptedValue(string attemptedValue, string expectedChecked) { // Arrange - var expected = @"" + - @""; + var expected = @"" + + @""; expected = string.Format(expected, expectedChecked); var viewData = GetTestModelViewData(); @@ -319,9 +319,9 @@ public void CheckBoxFor_UsesModelStateAttemptedValue(string attemptedValue, stri public void CheckBoxFor_WithObjectAttribute_MapsUnderscoresInNamesToDashes() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); var htmlAttributes = new { Property1_Property3 = "Property3ObjValue" }; @@ -336,9 +336,9 @@ public void CheckBoxFor_WithObjectAttribute_MapsUnderscoresInNamesToDashes() public void CheckBoxForWith_AttributeDictionary_GeneratesExpectedAttributes() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); var attributes = new Dictionary { { "Property3", "Property3Value" } }; @@ -353,9 +353,9 @@ public void CheckBoxForWith_AttributeDictionary_GeneratesExpectedAttributes() public void CheckBoxForWithPrefix() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; var attributes = new Dictionary { { "Property3", "PropValue" } }; @@ -371,9 +371,9 @@ public void CheckBoxForWithPrefix() public void CheckBoxFor_WithComplexExpressions_DoesNotUseValuesFromViewDataDictionary() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetModelWithValidationViewData()); // Act diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperFormTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperFormTest.cs index da82bf35fe..bb20e24b55 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperFormTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperFormTest.cs @@ -120,7 +120,7 @@ public void BeginForm_RendersExpectedValues_WithDefaultArguments() var path = "/Path"; var queryString = "?query=string"; var expectedAction = pathBase + path + queryString; - var expectedStartTag = string.Format("
", expectedAction); + var expectedStartTag = string.Format("", expectedAction); // IUrlHelper should not be used in this scenario. var urlHelper = new Mock(MockBehavior.Strict); @@ -167,7 +167,7 @@ public void BeginForm_RendersExpectedValues_WithDefaultArgumentsAndHtmlAttribute var queryString = "?query=string"; var expectedAction = pathBase + path + queryString; var htmlAttributes = new { p1_name = "p1-value" }; - var expectedStartTag = string.Format("", + var expectedStartTag = string.Format("", expectedAction, GetHtmlAttributesAsString(htmlAttributes)); @@ -219,7 +219,7 @@ public void BeginForm_RendersExpectedValues( // Arrange var expectedAction = "http://localhost/Hello/World"; var expectedStartTag = string.Format( - "", + "", expectedAction, method.ToString().ToLowerInvariant(), GetHtmlAttributesAsString(htmlAttributes)); @@ -261,7 +261,7 @@ public void BeginRouteForm_RendersExpectedValues( // Arrange var expectedAction = "http://localhost/Hello/World"; var expectedStartTag = string.Format( - "", + "", expectedAction, method.ToString().ToLowerInvariant(), GetHtmlAttributesAsString(htmlAttributes)); @@ -320,7 +320,7 @@ private string GetHtmlAttributesAsString(object htmlAttributes) var dictionary = HtmlHelper.AnonymousObjectToHtmlAttributes(htmlAttributes); return string.Join( string.Empty, - dictionary.Select(keyValue => string.Format(" {0}=\"{1}\"", keyValue.Key, keyValue.Value))); + dictionary.Select(keyValue => string.Format(" {0}=\"HtmlEncode[[{1}]]\"", keyValue.Key, keyValue.Value))); } } } \ No newline at end of file diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperHiddenTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperHiddenTest.cs index 56e49c14dd..ee2155a98a 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperHiddenTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperHiddenTest.cs @@ -18,13 +18,13 @@ public static IEnumerable HiddenWithAttributesData { get { - var expected1 = @""; + var expected1 = @""; yield return new object[] { new Dictionary { { "baz", "BazValue" } }, expected1 }; yield return new object[] { new { baz = "BazValue" }, expected1 }; - var expected2 = @""; + var expected2 = @""; yield return new object[] { new Dictionary { { "foo-baz", "BazValue" } }, expected2 }; yield return new object[] { new { foo_baz = "BazValue" }, expected2 }; } @@ -34,7 +34,7 @@ public static IEnumerable HiddenWithAttributesData public void HiddenWithByteArrayValue_GeneratesBase64EncodedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(); // Act @@ -63,7 +63,7 @@ public void HiddenWithArgumentValueAndAttributes_UsesArgumentValue(object attrib public void HiddenOverridesValueFromAttributesWithArgumentValue() { // Arrange - var expected = @""; + var expected = @""; var attributes = new { value = "attribute-value" }; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithNullModelAndNonNullViewData()); helper.ViewData.Clear(); @@ -79,8 +79,8 @@ public void HiddenOverridesValueFromAttributesWithArgumentValue() public void HiddenWithArgumentValueAndNullModel_UsesArgumentValue() { // Arrange - var expected = @""; + var expected = @""; var attributes = new { key = "value" }; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithNullModelAndNonNullViewData()); @@ -95,8 +95,8 @@ public void HiddenWithArgumentValueAndNullModel_UsesArgumentValue() public void HiddenWithNullValueAndNullModel_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var attributes = new Dictionary { { "data-key", "value" } }; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithNullModelAndNonNullViewData()); @@ -111,7 +111,7 @@ public void HiddenWithNullValueAndNullModel_GeneratesExpectedValue() public void HiddenUsesValuesFromModelState_OverExplicitSpecifiedValueAndPropertyValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.Model.Property1 = "test-value"; @@ -126,7 +126,7 @@ public void HiddenUsesValuesFromModelState_OverExplicitSpecifiedValueAndProperty public void HiddenUsesExplicitValue_IfModelStateDoesNotHaveProperty() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.ModelState.Clear(); helper.ViewData.Model.Property1 = "property-value"; @@ -142,7 +142,7 @@ public void HiddenUsesExplicitValue_IfModelStateDoesNotHaveProperty() public void HiddenUsesValueFromViewData_IfModelStateDoesNotHavePropertyAndExplicitValueIsNull() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.ModelState.Clear(); helper.ViewData.Model.Property1 = "property-value"; @@ -158,7 +158,7 @@ public void HiddenUsesValueFromViewData_IfModelStateDoesNotHavePropertyAndExplic public void HiddenUsesPropertyValue_IfModelStateAndViewDataDoNotHavePropertyAndExplicitValueIsNull() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.ModelState.Clear(); helper.ViewData.Clear(); @@ -175,7 +175,7 @@ public void HiddenUsesPropertyValue_IfModelStateAndViewDataDoNotHavePropertyAndE public void HiddenDoesNotUsesAttributeValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.ModelState.Clear(); helper.ViewData.Clear(); @@ -192,7 +192,7 @@ public void HiddenDoesNotUsesAttributeValue() public void HiddenReturnsEmptyValue_IfPropertyIsNotFound() { // Arrange - var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); var attributes = new Dictionary { { "baz", "BazValue" } }; @@ -208,8 +208,8 @@ public void HiddenReturnsEmptyValue_IfPropertyIsNotFound() public void HiddenWithPrefix_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; @@ -224,7 +224,7 @@ public void HiddenWithPrefix_GeneratesExpectedValue() public void HiddenWithPrefixAndEmptyName_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; @@ -239,8 +239,8 @@ public void HiddenWithPrefixAndEmptyName_GeneratesExpectedValue() public void HiddenUsesPrefixName_ToLookupPropertyValueInModelState() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; helper.IdAttributeDotReplacement = "$"; @@ -260,8 +260,8 @@ public void HiddenUsesPrefixName_ToLookupPropertyValueInModelState() public void HiddenUsesPrefixName_ToLookupPropertyValueInViewData() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; helper.IdAttributeDotReplacement = "$"; @@ -297,8 +297,8 @@ public void HiddenWithEmptyNameAndPrefixThrows() public void HiddenWithViewDataErrors_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithErrors()); var attributes = new Dictionary { @@ -317,8 +317,8 @@ public void HiddenWithViewDataErrors_GeneratesExpectedValue() public void HiddenGeneratesUnobtrusiveValidation() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); // Act @@ -335,22 +335,22 @@ public static IEnumerable HiddenWithComplexExpressions_UsesValueFromVi yield return new object[] { "Property3[height]", - @"", + @"", }; yield return new object[] { "Property4.Property5", - @"", + @"", }; yield return new object[] { "Property4.Property6[0]", - @"", + @"", }; } } @@ -381,15 +381,15 @@ public static IEnumerable HiddenWithComplexExpressions_UsesIdDotSepara yield return new object[] { "Property4.Property5", - @"", + @"", }; yield return new object[] { "Property4.Property6[0]", - @"", + @"", }; } } @@ -418,7 +418,7 @@ public void HiddenWithComplexExpressions_UsesIdDotSeparator(string expression, s public void HiddenForWithByteArrayValue_GeneratesBase64EncodedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.Model.Bytes = new byte[] { 23, 43, 53 }; @@ -448,7 +448,7 @@ public void HiddenForWithAttributes_GeneratesExpectedValue(object htmlAttributes public void HiddenFor_UsesModelStateValueOverPropertyValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.Model.Property1 = "DefaultValue"; @@ -463,7 +463,7 @@ public void HiddenFor_UsesModelStateValueOverPropertyValue() public void HiddenFor_UsesPropertyValueIfModelStateDoesNotHaveKey() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.ModelState.Clear(); helper.ViewData.Model.Property1 = "PropertyValue"; @@ -479,7 +479,7 @@ public void HiddenFor_UsesPropertyValueIfModelStateDoesNotHaveKey() public void HiddenForDoesNotUseValueFromViewDataDictionary_IfModelStateAndPropertyValueIsNull() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.Model.Property1 = null; helper.ViewData.ModelState.Clear(); @@ -495,7 +495,7 @@ public void HiddenForDoesNotUseValueFromViewDataDictionary_IfModelStateAndProper public void HiddenForWithAttributesDictionaryAndNullModel_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithNullModelAndNonNullViewData()); var attributes = new Dictionary { { "key", "value" } }; @@ -511,8 +511,8 @@ public void HiddenForWithAttributesDictionaryAndNullModel_GeneratesExpectedValue public void HiddenForWithPrefix_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.Model.Property1 = "propValue"; helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; @@ -528,8 +528,8 @@ public void HiddenForWithPrefix_GeneratesExpectedValue() public void HiddenForWithPrefix_UsesPrefixWhenLookingUpModelStateValues() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.Model.Property1 = "propValue"; helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; @@ -550,8 +550,8 @@ public void HiddenForWithPrefix_UsesPrefixWhenLookingUpModelStateValues() public void HiddenForWithViewDataErrors_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithErrors()); var attributes = new Dictionary { @@ -570,8 +570,8 @@ public void HiddenForWithViewDataErrors_GeneratesExpectedValue() public void HiddenFor_GeneratesUnobtrusiveValidationAttributes() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithErrors()); // Act @@ -591,23 +591,23 @@ public static TheoryData HiddenFor_UsesPropertyValueIfModelStateDoesNotContainVa { { model => model.Property3["key"], - @"" + @"" }, { model => model.Property4.Property5, - @"" + @"" }, { model => model.Property4.Property6[0], - @"" + @"" }, { model => localModel.Property4.Property5, - @"" + @"" } }; } @@ -650,18 +650,18 @@ public static TheoryData HiddenFor_UsesModelStateValueForComplexExpressionsData { { model => model.Property3["key"], - @"" + @"" }, { model => model.Property4.Property5, - @"" + @"" }, { model => model.Property4.Property6[0], - @"" + @"" } }; } @@ -694,7 +694,7 @@ public void HiddenFor_UsesModelStateValueForComplexExpressions( public void HiddenFor_DoesNotUseAttributeValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithNullModelAndNonNullViewData()); var attributes = new Dictionary { diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperLabelExtensionsTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperLabelExtensionsTest.cs index 730a11ddfd..d66b641ab9 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperLabelExtensionsTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperLabelExtensionsTest.cs @@ -43,8 +43,8 @@ public void LabelHelpers_DisplayPropertyName() var labelForResult = helper.LabelFor(m => m.Property1); // Assert - Assert.Equal("", labelResult.ToString()); - Assert.Equal("", labelForResult.ToString()); + Assert.Equal("", labelResult.ToString()); + Assert.Equal("", labelForResult.ToString()); } [Fact] @@ -58,8 +58,8 @@ public void LabelHelpers_DisplayPropertyName_ForNestedProperty() var labelForResult = helper.LabelFor(m => m.Inner.Id); // Assert - Assert.Equal("", labelResult.ToString()); - Assert.Equal("", labelForResult.ToString()); + Assert.Equal("", labelResult.ToString()); + Assert.Equal("", labelForResult.ToString()); } [Fact] @@ -83,9 +83,9 @@ public void LabelHelpers_DisplayMetadataPropertyNameForProperty() var labelForModelResult = helper.LabelForModel(); // Assert - Assert.Equal("", labelResult.ToString()); - Assert.Equal("", labelForResult.ToString()); - Assert.Equal("", labelForModelResult.ToString()); + Assert.Equal("", labelResult.ToString()); + Assert.Equal("", labelForResult.ToString()); + Assert.Equal("", labelForModelResult.ToString()); } // If the metadata is for a type (not property), then Label(expression) will evaluate the expression @@ -100,7 +100,7 @@ public void LabelHelpers_Label_Evaluates_Expression() var labelResult = helper.Label(expression: "value"); // Assert - Assert.Equal("", labelResult.ToString()); + Assert.Equal("", labelResult.ToString()); } [Fact] @@ -146,9 +146,9 @@ public void LabelHelpers_DisplayDisplayName_IfNonNull(string displayName) var labelForModelResult = helper.LabelForModel(); // Assert - Assert.Equal("", labelResult.ToString()); - Assert.Equal("", labelForResult.ToString()); - Assert.Equal("", labelForModelResult.ToString()); + Assert.Equal("", labelResult.ToString()); + Assert.Equal("", labelForResult.ToString()); + Assert.Equal("", labelForModelResult.ToString()); } [Fact] @@ -197,8 +197,8 @@ public void LabelHelpers_DisplayDisplayNameForProperty_IfNonNull(string displayN var labelForResult = helper.LabelFor(m => m.Property1); // Assert - Assert.Equal("", labelResult.ToString()); - Assert.Equal("", labelForResult.ToString()); + Assert.Equal("", labelResult.ToString()); + Assert.Equal("", labelForResult.ToString()); } [Theory] @@ -219,7 +219,7 @@ public void Label_DisplaysRightmostExpressionSegment_IfPropertiesNotFound( // Assert // Label() falls back to expression name when DisplayName and PropertyName are null. - Assert.Equal("", result.ToString()); + Assert.Equal("", result.ToString()); } [Fact] @@ -247,7 +247,7 @@ public void LabelFor_DisplaysVariableName() var result = helper.LabelFor(model => unknownKey); // Assert - Assert.Equal("", result.ToString()); + Assert.Equal("", result.ToString()); } private sealed class InnerClass diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperLinkGenerationTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperLinkGenerationTest.cs index a85830c629..e3dbd774df 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperLinkGenerationTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperLinkGenerationTest.cs @@ -45,7 +45,7 @@ public void ActionLink_GeneratesLink_WithExpectedValues( object htmlAttributes) { //Arrange - string expectedLink = string.Format(@"Details", + string expectedLink = string.Format(@"HtmlEncode[[Details]]", protocol, hostname, controller, @@ -53,6 +53,7 @@ public void ActionLink_GeneratesLink_WithExpectedValues( GetRouteValuesAsString(routeValues), fragment, GetHtmlAttributesAsString(htmlAttributes)); + expectedLink = expectedLink.Replace("HtmlEncode[[]]", ""); var urlHelper = new Mock(); urlHelper.Setup(h => h.Action(It.IsAny())) @@ -111,12 +112,13 @@ public void RouteLink_GeneratesLink_WithExpectedValues( object htmlAttributes) { //Arrange - string expectedLink = string.Format(@"Details", + string expectedLink = string.Format(@"HtmlEncode[[Details]]", protocol, hostname, GetRouteValuesAsString(routeValues), fragment, GetHtmlAttributesAsString(htmlAttributes)); + expectedLink = expectedLink.Replace("HtmlEncode[[]]", ""); var urlHelper = new Mock(); urlHelper @@ -153,7 +155,7 @@ private string GetRouteValuesAsString(object routeValues) private string GetHtmlAttributesAsString(object routeValues) { var dict = TypeHelper.ObjectToDictionary(routeValues); - return string.Join(string.Empty, dict.Select(kvp => string.Format(" {0}=\"{1}\"", kvp.Key, kvp.Value.ToString()))); + return string.Join(string.Empty, dict.Select(kvp => string.Format(" {0}=\"HtmlEncode[[{1}]]\"", kvp.Key, kvp.Value.ToString()))); } } } \ No newline at end of file diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperPasswordTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperPasswordTest.cs index 8a3c8e639b..0135ac9cf3 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperPasswordTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperPasswordTest.cs @@ -43,8 +43,8 @@ public void Password_UsesAttributeValueWhenValueArgumentIsNull(ViewDataDictionar object attributes) { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(vdd); // Act @@ -60,8 +60,8 @@ public void Password_UsesExplicitValue_IfSpecified(ViewDataDictionary"; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(vdd); // Act @@ -75,8 +75,8 @@ public void Password_UsesExplicitValue_IfSpecified(ViewDataDictionary"; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; @@ -91,8 +91,8 @@ public void PasswordWithPrefix_GeneratesExpectedValue() public void PasswordWithPrefix_UsesIdDotReplacementToken() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; helper.IdAttributeDotReplacement = "$"; @@ -108,7 +108,7 @@ public void PasswordWithPrefix_UsesIdDotReplacementToken() public void PasswordWithPrefixAndEmptyName_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; var name = string.Empty; @@ -137,8 +137,8 @@ public void PasswordWithEmptyNameAndPrefixThrows() public void Password_UsesModelStateErrors_ButDoesNotUseModelOrViewDataOrModelStateForValueAttribute() { // Arrange - var expected = @""; + var expected = @""; var vdd = GetViewDataWithErrors(); vdd.Model.Property1 = "property-value"; var helper = DefaultTemplatesUtilities.GetHtmlHelper(vdd); @@ -159,8 +159,8 @@ public void Password_UsesModelStateErrors_ButDoesNotUseModelOrViewDataOrModelSta public void PasswordGeneratesUnobtrusiveValidation() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); // Act @@ -177,15 +177,15 @@ public static IEnumerable PasswordWithComplexExpressions_UsesIdDotSepa yield return new object[] { "Property4.Property5", - @"", + @"", }; yield return new object[] { "Property4.Property6[0]", - @"", + @"", }; } } @@ -213,8 +213,8 @@ public void PasswordForWithAttributes_GeneratesExpectedValue(ViewDataDictionary< object htmlAttributes) { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewData.Model.Property1 = "test"; @@ -229,7 +229,7 @@ public void PasswordForWithAttributes_GeneratesExpectedValue(ViewDataDictionary< public void PasswordForWithPrefix_GeneratesExpectedValue() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithModelStateAndModelAndViewDataValues()); helper.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = "MyPrefix"; @@ -244,8 +244,8 @@ public void PasswordForWithPrefix_GeneratesExpectedValue() public void PasswordFor_UsesModelStateErrors_ButDoesNotUseModelOrViewDataOrModelStateForValueAttribute() { // Arrange - var expected = @""; + var expected = @""; var vdd = GetViewDataWithErrors(); vdd.Model.Property1 = "prop1-value"; var helper = DefaultTemplatesUtilities.GetHtmlHelper(vdd); @@ -266,8 +266,8 @@ public void PasswordFor_UsesModelStateErrors_ButDoesNotUseModelOrViewDataOrModel public void PasswordFor_GeneratesUnobtrusiveValidationAttributes() { // Arrange - var expected = @""; + var expected = @""; var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetViewDataWithErrors()); // Act @@ -285,18 +285,18 @@ public static TheoryData PasswordFor_WithComplexExpressionsData { { model => model.Property3["key"], - @"" + @"" }, { model => model.Property4.Property5, - @"" + @"" }, { model => model.Property4.Property6[0], - @"" + @"" } }; } diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperSelectTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperSelectTest.cs index cf972b1adf..20ebf07213 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperSelectTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperSelectTest.cs @@ -69,93 +69,93 @@ public static TheoryData, string, string> DropDownLi { { BasicSelectList, - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" }, { SomeDisabledOneSelectedSelectList, - "" + Environment.NewLine + - "" + + "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" }, { SomeGroupedSomeSelectedSelectList, - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + "" }, { OneGroupSomeSelectedSelectList, - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "" }, { OneDisabledGroupAllSelectedSelectList, - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "" }, @@ -172,131 +172,131 @@ public static TheoryData, string, string, string> Li { { BasicSelectList, - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" }, { SomeDisabledOneSelectedSelectList, - "" + Environment.NewLine + - "" + + "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" }, { SomeGroupedSomeSelectedSelectList, - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + "" }, { OneGroupSomeSelectedSelectList, - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "", - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "" }, { OneDisabledGroupAllSelectedSelectList, - "" + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "", - "" + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "", - "" + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + "" + Environment.NewLine + "" }, @@ -476,11 +476,11 @@ public void DropDownListFor_WithIndexerExpression_GeneratesExpectedValue() var selectList = SomeDisabledOneSelectedSelectList; var savedSelected = selectList.Select(item => item.Selected).ToList(); var expectedHtml = - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + ""; // Act @@ -504,10 +504,10 @@ public void DropDownListFor_WithUnrelatedExpression_GeneratesExpectedValue() var selectList = SomeDisabledOneSelectedSelectList; var savedSelected = selectList.Select(item => item.Selected).ToList(); var expectedHtml = - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + ""; // Act @@ -638,11 +638,11 @@ public void ListBoxFor_WithUnreleatedExpression_GeneratesExpectedValue() var selectList = SomeDisabledOneSelectedSelectList; var savedSelected = selectList.Select(item => item.Selected).ToList(); var expectedHtml = - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + - "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + + "" + Environment.NewLine + ""; // Act diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperValidationSummaryTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperValidationSummaryTest.cs index d0173db950..81eb0364db 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperValidationSummaryTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperValidationSummaryTest.cs @@ -23,29 +23,29 @@ public static TheoryData ValidValidationSummaryD { "attribute-name", "attribute-value" }, }; - var basicDiv = "
" + + var basicDiv = "
" + "
  • " + Environment.NewLine + "
"; - var divWithAttributes = "
    " + + var divWithAttributes = "
      " + "
    • " + Environment.NewLine + "
    "; - var divWithMessage = "
    " + - "This is my message" + Environment.NewLine + + var divWithMessage = "
    " + + "HtmlEncode[[This is my message]]" + Environment.NewLine + "
    • " + Environment.NewLine + "
    "; - var divWithH3Message = "
    " + - "

    This is my message

    " + Environment.NewLine + + var divWithH3Message = "
    " + + "

    HtmlEncode[[This is my message]]

    " + Environment.NewLine + "
    • " + Environment.NewLine + "
    "; - var divWithMessageAndAttributes = "
    " + - "This is my message" + Environment.NewLine + + var divWithMessageAndAttributes = "
    " + + "HtmlEncode[[This is my message]]" + Environment.NewLine + "
    • " + Environment.NewLine + "
    "; - var divWithH3MessageAndAttributes = "
    " + - "

    This is my message

    " + Environment.NewLine + + var divWithH3MessageAndAttributes = "
    " + + "

    HtmlEncode[[This is my message]]

    " + Environment.NewLine + "
    • " + Environment.NewLine + "
    "; @@ -72,14 +72,14 @@ public static TheoryData OneErrorValidationSummaryDa { get { - var basicDiv = "
      " + + var basicDiv = "
        " + "
      • " + Environment.NewLine + "
      "; - var divWithError = "
        " + - "
      • This is my validation message
      • " + Environment.NewLine + + var divWithError = "
          " + + "
        • HtmlEncode[[This is my validation message]]
        • " + Environment.NewLine + "
        "; - var divWithErrorAndSummary = "
          " + - "
        • This is my validation message
        • " + Environment.NewLine + + var divWithErrorAndSummary = "
            " + + "
          • HtmlEncode[[This is my validation message]]
          • " + Environment.NewLine + "
          "; return new TheoryData @@ -97,25 +97,25 @@ public static TheoryData MultipleErrorsValidationSummaryDa { get { - var basicDiv = "
            " + + var basicDiv = "
              " + "
            • " + Environment.NewLine + "
            "; - var divWithRootError = "
              " + - "
            • This is an error for the model root.
            • " + Environment.NewLine + - "
            • This is another error for the model root.
            • " + Environment.NewLine + + var divWithRootError = "
                " + + "
              • HtmlEncode[[This is an error for the model root.]]
              • " + Environment.NewLine + + "
              • HtmlEncode[[This is another error for the model root.]]
              • " + Environment.NewLine + "
              "; - var divWithProperty3Error = "
                " + - "
              • This is an error for Property3.
              • " + Environment.NewLine + + var divWithProperty3Error = "
                  " + + "
                • HtmlEncode[[This is an error for Property3.]]
                • " + Environment.NewLine + "
                "; - var divWithAllErrors = "
                  " + - "
                • This is an error for Property3.Property2.
                • " + Environment.NewLine + - "
                • This is an error for Property3.OrderedProperty3.
                • " + Environment.NewLine + - "
                • This is an error for Property3.OrderedProperty2.
                • " + Environment.NewLine + - "
                • This is an error for Property3.
                • " + Environment.NewLine + - "
                • This is an error for Property2.
                • " + Environment.NewLine + - "
                • This is another error for Property2.
                • " + Environment.NewLine + - "
                • This is an error for the model root.
                • " + Environment.NewLine + - "
                • This is another error for the model root.
                • " + Environment.NewLine + + var divWithAllErrors = "
                    " + + "
                  • HtmlEncode[[This is an error for Property3.Property2.]]
                  • " + Environment.NewLine + + "
                  • HtmlEncode[[This is an error for Property3.OrderedProperty3.]]
                  • " + Environment.NewLine + + "
                  • HtmlEncode[[This is an error for Property3.OrderedProperty2.]]
                  • " + Environment.NewLine + + "
                  • HtmlEncode[[This is an error for Property3.]]
                  • " + Environment.NewLine + + "
                  • HtmlEncode[[This is an error for Property2.]]
                  • " + Environment.NewLine + + "
                  • HtmlEncode[[This is another error for Property2.]]
                  • " + Environment.NewLine + + "
                  • HtmlEncode[[This is an error for the model root.]]
                  • " + Environment.NewLine + + "
                  • HtmlEncode[[This is another error for the model root.]]
                  • " + Environment.NewLine + "
                  "; return new TheoryData @@ -304,18 +304,18 @@ public void ValidationSummary_MultipleErrors_ReturnsExpectedDiv( public void ValidationSummary_ErrorsInModelUsingOrder_SortsErrorsAsExpected() { // Arrange - var expected = "
                    " + - "
                  • This is an error for OrderedProperty3.
                  • " + Environment.NewLine + - "
                  • This is an error for OrderedProperty2.
                  • " + Environment.NewLine + - "
                  • This is another error for OrderedProperty2.
                  • " + Environment.NewLine + - "
                  • This is yet-another error for OrderedProperty2.
                  • " + Environment.NewLine + - "
                  • This is an error for OrderedProperty1.
                  • " + Environment.NewLine + - "
                  • This is an error for Property3.
                  • " + Environment.NewLine + - "
                  • This is an error for Property2.
                  • " + Environment.NewLine + - "
                  • This is another error for Property2.
                  • " + Environment.NewLine + - "
                  • This is an error for Property1.
                  • " + Environment.NewLine + - "
                  • This is another error for Property1.
                  • " + Environment.NewLine + - "
                  • This is an error for LastProperty.
                  • " + Environment.NewLine + + var expected = "
                      " + + "
                    • HtmlEncode[[This is an error for OrderedProperty3.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is an error for OrderedProperty2.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is another error for OrderedProperty2.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is yet-another error for OrderedProperty2.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is an error for OrderedProperty1.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is an error for Property3.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is an error for Property2.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is another error for Property2.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is an error for Property1.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is another error for Property1.]]
                    • " + Environment.NewLine + + "
                    • HtmlEncode[[This is an error for LastProperty.]]
                    • " + Environment.NewLine + "
                    "; var model = new OrderedModel();