diff --git a/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/AuthorizationContext.cs b/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/AuthorizationFilterContext.cs similarity index 82% rename from src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/AuthorizationContext.cs rename to src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/AuthorizationFilterContext.cs index 442c940c67..19354819bd 100644 --- a/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/AuthorizationContext.cs +++ b/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/AuthorizationFilterContext.cs @@ -6,9 +6,9 @@ namespace Microsoft.AspNetCore.Mvc.Filters { - public class AuthorizationContext : FilterContext + public class AuthorizationFilterContext : FilterContext { - public AuthorizationContext( + public AuthorizationFilterContext( ActionContext actionContext, IList filters) : base(actionContext, filters) diff --git a/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAsyncAuthorizationFilter.cs b/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAsyncAuthorizationFilter.cs index e1ec0d5d1d..734dcedeb4 100644 --- a/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAsyncAuthorizationFilter.cs +++ b/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAsyncAuthorizationFilter.cs @@ -7,6 +7,6 @@ namespace Microsoft.AspNetCore.Mvc.Filters { public interface IAsyncAuthorizationFilter : IFilterMetadata { - Task OnAuthorizationAsync(AuthorizationContext context); + Task OnAuthorizationAsync(AuthorizationFilterContext context); } } diff --git a/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAuthorizationFilter.cs b/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAuthorizationFilter.cs index d352b83b81..d2f3a9cfb1 100644 --- a/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAuthorizationFilter.cs +++ b/src/Microsoft.AspNetCore.Mvc.Abstractions/Filters/IAuthorizationFilter.cs @@ -5,6 +5,6 @@ namespace Microsoft.AspNetCore.Mvc.Filters { public interface IAuthorizationFilter : IFilterMetadata { - void OnAuthorization(AuthorizationContext context); + void OnAuthorization(AuthorizationFilterContext context); } } diff --git a/src/Microsoft.AspNetCore.Mvc.Core/Filters/AuthorizationFilterAttribute.cs b/src/Microsoft.AspNetCore.Mvc.Core/Filters/AuthorizationFilterAttribute.cs index 8e054dac9a..10c9925aae 100644 --- a/src/Microsoft.AspNetCore.Mvc.Core/Filters/AuthorizationFilterAttribute.cs +++ b/src/Microsoft.AspNetCore.Mvc.Core/Filters/AuthorizationFilterAttribute.cs @@ -15,7 +15,7 @@ public abstract class AuthorizationFilterAttribute : { public int Order { get; set; } - public virtual Task OnAuthorizationAsync(AuthorizationContext context) + public virtual Task OnAuthorizationAsync(AuthorizationFilterContext context) { if (context == null) { @@ -26,11 +26,11 @@ public virtual Task OnAuthorizationAsync(AuthorizationContext context) return TaskCache.CompletedTask; } - public virtual void OnAuthorization(AuthorizationContext context) + public virtual void OnAuthorization(AuthorizationFilterContext context) { } - protected virtual bool HasAllowAnonymous(AuthorizationContext context) + protected virtual bool HasAllowAnonymous(AuthorizationFilterContext context) { if (context == null) { @@ -40,7 +40,7 @@ protected virtual bool HasAllowAnonymous(AuthorizationContext context) return context.Filters.Any(item => item is IAllowAnonymousFilter); } - protected virtual void Fail(AuthorizationContext context) + protected virtual void Fail(AuthorizationFilterContext context) { if (context == null) { diff --git a/src/Microsoft.AspNetCore.Mvc.Core/Internal/AuthorizeFilter.cs b/src/Microsoft.AspNetCore.Mvc.Core/Internal/AuthorizeFilter.cs index db691ac04c..1984cb4115 100644 --- a/src/Microsoft.AspNetCore.Mvc.Core/Internal/AuthorizeFilter.cs +++ b/src/Microsoft.AspNetCore.Mvc.Core/Internal/AuthorizeFilter.cs @@ -37,7 +37,7 @@ public AuthorizeFilter(AuthorizationPolicy policy) public AuthorizationPolicy Policy { get; private set; } /// - public virtual async Task OnAuthorizationAsync(Filters.AuthorizationContext context) + public virtual async Task OnAuthorizationAsync(Filters.AuthorizationFilterContext context) { if (context == null) { diff --git a/src/Microsoft.AspNetCore.Mvc.Core/Internal/FilterActionInvoker.cs b/src/Microsoft.AspNetCore.Mvc.Core/Internal/FilterActionInvoker.cs index 3798cd8498..703b552770 100644 --- a/src/Microsoft.AspNetCore.Mvc.Core/Internal/FilterActionInvoker.cs +++ b/src/Microsoft.AspNetCore.Mvc.Core/Internal/FilterActionInvoker.cs @@ -29,7 +29,7 @@ public abstract class FilterActionInvoker : IActionInvoker private IFilterMetadata[] _filters; private FilterCursor _cursor; - private AuthorizationContext _authorizationContext; + private AuthorizationFilterContext _authorizationContext; private ResourceExecutingContext _resourceExecutingContext; private ResourceExecutedContext _resourceExecutedContext; @@ -186,7 +186,7 @@ private Task InvokeAllAuthorizationFiltersAsync() { _cursor.Reset(); - _authorizationContext = new AuthorizationContext(Context, _filters); + _authorizationContext = new AuthorizationFilterContext(Context, _filters); return InvokeAuthorizationFilterAsync(); } diff --git a/src/Microsoft.AspNetCore.Mvc.Core/Internal/MvcCoreDiagnosticSourceExtensions.cs b/src/Microsoft.AspNetCore.Mvc.Core/Internal/MvcCoreDiagnosticSourceExtensions.cs index 79086cf137..bc8666508e 100644 --- a/src/Microsoft.AspNetCore.Mvc.Core/Internal/MvcCoreDiagnosticSourceExtensions.cs +++ b/src/Microsoft.AspNetCore.Mvc.Core/Internal/MvcCoreDiagnosticSourceExtensions.cs @@ -42,7 +42,7 @@ public static void AfterAction( public static void BeforeOnAuthorizationAsync( this DiagnosticSource diagnosticSource, - AuthorizationContext authorizationContext, + AuthorizationFilterContext authorizationContext, IAsyncAuthorizationFilter filter) { if (diagnosticSource.IsEnabled("Microsoft.AspNetCore.Mvc.BeforeOnAuthorization")) @@ -60,7 +60,7 @@ public static void BeforeOnAuthorizationAsync( public static void AfterOnAuthorizationAsync( this DiagnosticSource diagnosticSource, - AuthorizationContext authorizationContext, + AuthorizationFilterContext authorizationContext, IAsyncAuthorizationFilter filter) { if (diagnosticSource.IsEnabled("Microsoft.AspNetCore.Mvc.AfterOnAuthorization")) @@ -78,7 +78,7 @@ public static void AfterOnAuthorizationAsync( public static void BeforeOnAuthorization( this DiagnosticSource diagnosticSource, - AuthorizationContext authorizationContext, + AuthorizationFilterContext authorizationContext, IAuthorizationFilter filter) { if (diagnosticSource.IsEnabled("Microsoft.AspNetCore.Mvc.BeforeOnAuthorization")) @@ -96,7 +96,7 @@ public static void BeforeOnAuthorization( public static void AfterOnAuthorization( this DiagnosticSource diagnosticSource, - AuthorizationContext authorizationContext, + AuthorizationFilterContext authorizationContext, IAuthorizationFilter filter) { if (diagnosticSource.IsEnabled("Microsoft.AspNetCore.Mvc.AfterOnAuthorization")) diff --git a/src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs b/src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs index a272fc5ce1..cee2a92219 100644 --- a/src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs +++ b/src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs @@ -12,7 +12,7 @@ public class RequireHttpsAttribute : Attribute, IAuthorizationFilter, IOrderedFi { public int Order { get; set; } - public virtual void OnAuthorization(AuthorizationContext filterContext) + public virtual void OnAuthorization(AuthorizationFilterContext filterContext) { if (filterContext == null) { @@ -25,7 +25,7 @@ public virtual void OnAuthorization(AuthorizationContext filterContext) } } - protected virtual void HandleNonHttpsRequest(AuthorizationContext filterContext) + protected virtual void HandleNonHttpsRequest(AuthorizationFilterContext filterContext) { // only redirect for GET requests, otherwise the browser might not propagate the verb and request // body correctly. diff --git a/src/Microsoft.AspNetCore.Mvc.Cors/Internal/CorsAuthorizationFilter.cs b/src/Microsoft.AspNetCore.Mvc.Cors/Internal/CorsAuthorizationFilter.cs index a2483043f1..fdbf6cf2fb 100644 --- a/src/Microsoft.AspNetCore.Mvc.Cors/Internal/CorsAuthorizationFilter.cs +++ b/src/Microsoft.AspNetCore.Mvc.Cors/Internal/CorsAuthorizationFilter.cs @@ -49,7 +49,7 @@ public int Order /// - public async Task OnAuthorizationAsync(Filters.AuthorizationContext context) + public async Task OnAuthorizationAsync(Filters.AuthorizationFilterContext context) { if (context == null) { diff --git a/src/Microsoft.AspNetCore.Mvc.Cors/Internal/DisableCorsAuthorizationFilter.cs b/src/Microsoft.AspNetCore.Mvc.Cors/Internal/DisableCorsAuthorizationFilter.cs index 0ff5718f99..a8a6d5d9dd 100644 --- a/src/Microsoft.AspNetCore.Mvc.Cors/Internal/DisableCorsAuthorizationFilter.cs +++ b/src/Microsoft.AspNetCore.Mvc.Cors/Internal/DisableCorsAuthorizationFilter.cs @@ -27,7 +27,7 @@ public int Order } /// - public Task OnAuthorizationAsync(AuthorizationContext context) + public Task OnAuthorizationAsync(AuthorizationFilterContext context) { if (context == null) { diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/AutoValidateAntiforgeryTokenAuthorizationFilter.cs b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/AutoValidateAntiforgeryTokenAuthorizationFilter.cs index 8adca431fa..f159ed2da3 100644 --- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/AutoValidateAntiforgeryTokenAuthorizationFilter.cs +++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/AutoValidateAntiforgeryTokenAuthorizationFilter.cs @@ -15,7 +15,7 @@ public AutoValidateAntiforgeryTokenAuthorizationFilter(IAntiforgery antiforgery, { } - protected override bool ShouldValidate(AuthorizationContext context) + protected override bool ShouldValidate(AuthorizationFilterContext context) { if (context == null) { diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/ValidateAntiforgeryTokenAuthorizationFilter.cs b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/ValidateAntiforgeryTokenAuthorizationFilter.cs index f981c33484..43dd1c3920 100644 --- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/ValidateAntiforgeryTokenAuthorizationFilter.cs +++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/ValidateAntiforgeryTokenAuthorizationFilter.cs @@ -27,7 +27,7 @@ public ValidateAntiforgeryTokenAuthorizationFilter(IAntiforgery antiforgery, ILo _logger = loggerFactory.CreateLogger(); } - public async Task OnAuthorizationAsync(AuthorizationContext context) + public async Task OnAuthorizationAsync(AuthorizationFilterContext context) { if (context == null) { @@ -48,7 +48,7 @@ public async Task OnAuthorizationAsync(AuthorizationContext context) } } - protected virtual bool ShouldValidate(AuthorizationContext context) + protected virtual bool ShouldValidate(AuthorizationFilterContext context) { if (context == null) { diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/AuthorizeFilterTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/AuthorizeFilterTest.cs index 828f36351c..ccb6279a92 100644 --- a/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/AuthorizeFilterTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/AuthorizeFilterTest.cs @@ -274,7 +274,7 @@ public async Task Invoke_CanFilterToOnlyBearerScheme() Assert.NotNull(authorizationContext.Result); } - private Filters.AuthorizationContext GetAuthorizationContext( + private Filters.AuthorizationFilterContext GetAuthorizationContext( Action registerServices, bool anonymous = false) { @@ -325,13 +325,13 @@ private Filters.AuthorizationContext GetAuthorizationContext( auth.Setup(c => c.AuthenticateAsync("Basic")).ReturnsAsync(basicPrincipal); auth.Setup(c => c.AuthenticateAsync("Fails")).ReturnsAsync(null); - // AuthorizationContext + // AuthorizationFilterContext var actionContext = new ActionContext( httpContext: httpContext.Object, routeData: new RouteData(), actionDescriptor: new ActionDescriptor()); - var authorizationContext = new Filters.AuthorizationContext( + var authorizationContext = new Filters.AuthorizationFilterContext( actionContext, Enumerable.Empty().ToList() ); diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ControllerActionInvokerTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ControllerActionInvokerTest.cs index 6074747ab8..a3e4e33b6c 100644 --- a/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ControllerActionInvokerTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ControllerActionInvokerTest.cs @@ -254,7 +254,7 @@ public async Task InvokeAction_InvokesAuthorizationFilter() { // Arrange var filter = new Mock(MockBehavior.Strict); - filter.Setup(f => f.OnAuthorization(It.IsAny())).Verifiable(); + filter.Setup(f => f.OnAuthorization(It.IsAny())).Verifiable(); var invoker = CreateInvoker(filter.Object); @@ -262,7 +262,7 @@ public async Task InvokeAction_InvokesAuthorizationFilter() await invoker.InvokeAsync(); // Assert - filter.Verify(f => f.OnAuthorization(It.IsAny()), Times.Once()); + filter.Verify(f => f.OnAuthorization(It.IsAny()), Times.Once()); } [Fact] @@ -271,8 +271,8 @@ public async Task InvokeAction_InvokesAsyncAuthorizationFilter() // Arrange var filter = new Mock(MockBehavior.Strict); filter - .Setup(f => f.OnAuthorizationAsync(It.IsAny())) - .Returns(context => Task.FromResult(true)) + .Setup(f => f.OnAuthorizationAsync(It.IsAny())) + .Returns(context => Task.FromResult(true)) .Verifiable(); var invoker = CreateInvoker(filter.Object); @@ -282,7 +282,7 @@ public async Task InvokeAction_InvokesAsyncAuthorizationFilter() // Assert filter.Verify( - f => f.OnAuthorizationAsync(It.IsAny()), + f => f.OnAuthorizationAsync(It.IsAny()), Times.Once()); } @@ -294,8 +294,8 @@ public async Task InvokeAction_InvokesAuthorizationFilter_ShortCircuit() var filter1 = new Mock(MockBehavior.Strict); filter1 - .Setup(f => f.OnAuthorization(It.IsAny())) - .Callback(c => c.Result = challenge) + .Setup(f => f.OnAuthorization(It.IsAny())) + .Callback(c => c.Result = challenge) .Verifiable(); var filter2 = new Mock(MockBehavior.Strict); @@ -306,7 +306,7 @@ public async Task InvokeAction_InvokesAuthorizationFilter_ShortCircuit() await invoker.InvokeAsync(); // Assert - filter1.Verify(f => f.OnAuthorization(It.IsAny()), Times.Once()); + filter1.Verify(f => f.OnAuthorization(It.IsAny()), Times.Once()); Assert.False(invoker.ControllerFactory.CreateCalled); } @@ -318,8 +318,8 @@ public async Task InvokeAction_InvokesAsyncAuthorizationFilter_ShortCircuit() var filter1 = new Mock(MockBehavior.Strict); filter1 - .Setup(f => f.OnAuthorizationAsync(It.IsAny())) - .Returns((context) => + .Setup(f => f.OnAuthorizationAsync(It.IsAny())) + .Returns((context) => { context.Result = challenge; return Task.FromResult(true); @@ -335,7 +335,7 @@ public async Task InvokeAction_InvokesAsyncAuthorizationFilter_ShortCircuit() // Assert filter1.Verify( - f => f.OnAuthorizationAsync(It.IsAny()), + f => f.OnAuthorizationAsync(It.IsAny()), Times.Once()); Assert.False(invoker.ControllerFactory.CreateCalled); @@ -359,8 +359,8 @@ public async Task InvokeAction_ExceptionInAuthorizationFilterCannotBeHandledByOt var authorizationFilter1 = new Mock(MockBehavior.Strict); authorizationFilter1 - .Setup(f => f.OnAuthorization(It.IsAny())) - .Callback(c => { throw expected; }) + .Setup(f => f.OnAuthorization(It.IsAny())) + .Callback(c => { throw expected; }) .Verifiable(); // None of these filters should run @@ -385,7 +385,7 @@ public async Task InvokeAction_ExceptionInAuthorizationFilterCannotBeHandledByOt // Assert Assert.Same(expected, thrown); exceptionFilter.Verify(f => f.OnException(It.IsAny()), Times.Never()); - authorizationFilter1.Verify(f => f.OnAuthorization(It.IsAny()), Times.Once()); + authorizationFilter1.Verify(f => f.OnAuthorization(It.IsAny()), Times.Once()); } [Fact] @@ -400,8 +400,8 @@ public async Task InvokeAction_InvokesAuthorizationFilter_ChallengeNotSeenByResu var authorizationFilter = new Mock(MockBehavior.Strict); authorizationFilter - .Setup(f => f.OnAuthorization(It.IsAny())) - .Callback(c => c.Result = challenge.Object) + .Setup(f => f.OnAuthorization(It.IsAny())) + .Callback(c => c.Result = challenge.Object) .Verifiable(); var resultFilter = new Mock(MockBehavior.Strict); @@ -412,7 +412,7 @@ public async Task InvokeAction_InvokesAuthorizationFilter_ChallengeNotSeenByResu await invoker.InvokeAsync(); // Assert - authorizationFilter.Verify(f => f.OnAuthorization(It.IsAny()), Times.Once()); + authorizationFilter.Verify(f => f.OnAuthorization(It.IsAny()), Times.Once()); challenge.Verify(c => c.ExecuteResultAsync(It.IsAny()), Times.Once()); } @@ -1848,8 +1848,8 @@ public async Task InvokeAction_AuthorizationFilter_ChallengePreventsResourceFilt var authorizationFilter = new Mock(MockBehavior.Strict); authorizationFilter - .Setup(f => f.OnAuthorization(It.IsAny())) - .Callback((c) => + .Setup(f => f.OnAuthorization(It.IsAny())) + .Callback((c) => { c.Result = _result; }); @@ -2283,7 +2283,7 @@ public MockAuthorizationFilter(int maxAllowedErrors) _expectedMaxAllowedErrors = maxAllowedErrors; } - public void OnAuthorization(AuthorizationContext context) + public void OnAuthorization(AuthorizationFilterContext context) { Assert.NotNull(context.ModelState.MaxAllowedErrors); Assert.Equal(_expectedMaxAllowedErrors, context.ModelState.MaxAllowedErrors); diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/DefaultApplicationModelProviderTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/DefaultApplicationModelProviderTest.cs index 1931340373..3978cf66c6 100644 --- a/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/DefaultApplicationModelProviderTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/DefaultApplicationModelProviderTest.cs @@ -1191,7 +1191,7 @@ public void OnResultExecuting(ResultExecutingContext context) private class UnsupportedFiltersController : IExceptionFilter, IAuthorizationFilter, IAsyncResourceFilter { - public void OnAuthorization(AuthorizationContext context) + public void OnAuthorization(AuthorizationFilterContext context) { throw new NotImplementedException(); } diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/RequireHttpsAttributeTests.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/RequireHttpsAttributeTests.cs index 7d1e2c9cfa..4ba77b4e3e 100644 --- a/test/Microsoft.AspNetCore.Mvc.Core.Test/RequireHttpsAttributeTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/RequireHttpsAttributeTests.cs @@ -149,16 +149,16 @@ public void HandleNonHttpsRequestExtensibility() private class CustomRequireHttpsAttribute : RequireHttpsAttribute { - protected override void HandleNonHttpsRequest(AuthorizationContext filterContext) + protected override void HandleNonHttpsRequest(AuthorizationFilterContext filterContext) { filterContext.Result = new HttpStatusCodeResult(StatusCodes.Status404NotFound); } } - private static AuthorizationContext CreateAuthorizationContext(HttpContext ctx) + private static AuthorizationFilterContext CreateAuthorizationContext(HttpContext ctx) { var actionContext = new ActionContext(ctx, new RouteData(), new ActionDescriptor()); - return new AuthorizationContext(actionContext, new IFilterMetadata[0]); + return new AuthorizationFilterContext(actionContext, new IFilterMetadata[0]); } } } \ No newline at end of file diff --git a/test/Microsoft.AspNetCore.Mvc.Cors.Test/Internal/CorsAuthorizationFilterTest.cs b/test/Microsoft.AspNetCore.Mvc.Cors.Test/Internal/CorsAuthorizationFilterTest.cs index 2a90106883..13652c7eb6 100644 --- a/test/Microsoft.AspNetCore.Mvc.Cors.Test/Internal/CorsAuthorizationFilterTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.Cors.Test/Internal/CorsAuthorizationFilterTest.cs @@ -127,7 +127,7 @@ private CorsAuthorizationFilter GetFilter(ICorsService corsService) }; } - private AuthorizationContext GetAuthorizationContext( + private AuthorizationFilterContext GetAuthorizationContext( FilterDescriptor[] filterDescriptors, RequestHeaders headers = null, bool isPreflight = false) @@ -150,13 +150,13 @@ private AuthorizationContext GetAuthorizationContext( var method = isPreflight ? CorsConstants.PreflightHttpMethod : "GET"; httpContext.Request.Method = method; - // AuthorizationContext + // AuthorizationFilterContext var actionContext = new ActionContext( httpContext: httpContext, routeData: new RouteData(), actionDescriptor: new ActionDescriptor() { FilterDescriptors = filterDescriptors }); - var authorizationContext = new AuthorizationContext( + var authorizationContext = new AuthorizationFilterContext( actionContext, filterDescriptors.Select(filter => filter.Filter).ToList() ); diff --git a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/AutoValidateAntiforgeryTokenAuthorizationFilterTest.cs b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/AutoValidateAntiforgeryTokenAuthorizationFilterTest.cs index 9d399199cd..ec6209093b 100644 --- a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/AutoValidateAntiforgeryTokenAuthorizationFilterTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/AutoValidateAntiforgeryTokenAuthorizationFilterTest.cs @@ -34,7 +34,7 @@ public async Task Filter_ValidatesAntiforgery_ForUnsafeMethod(string httpMethod) var actionContext = new ActionContext(new DefaultHttpContext(), new RouteData(), new ActionDescriptor()); actionContext.HttpContext.Request.Method = httpMethod; - var context = new AuthorizationContext(actionContext, new[] { filter }); + var context = new AuthorizationFilterContext(actionContext, new[] { filter }); // Act await filter.OnAuthorizationAsync(context); @@ -62,7 +62,7 @@ public async Task Filter_SkipsAntiforgeryVerification_ForSafeMethod(string httpM var actionContext = new ActionContext(new DefaultHttpContext(), new RouteData(), new ActionDescriptor()); actionContext.HttpContext.Request.Method = httpMethod; - var context = new AuthorizationContext(actionContext, new[] { filter }); + var context = new AuthorizationFilterContext(actionContext, new[] { filter }); // Act await filter.OnAuthorizationAsync(context); @@ -86,7 +86,7 @@ public async Task Filter_SkipsAntiforgeryVerification_WhenOverridden() var actionContext = new ActionContext(new DefaultHttpContext(), new RouteData(), new ActionDescriptor()); actionContext.HttpContext.Request.Method = "POST"; - var context = new AuthorizationContext(actionContext, new IFilterMetadata[] + var context = new AuthorizationFilterContext(actionContext, new IFilterMetadata[] { filter, new IgnoreAntiforgeryTokenAttribute(), diff --git a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/ValidateAntiforgeryTokenAuthorizationFilterTest.cs b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/ValidateAntiforgeryTokenAuthorizationFilterTest.cs index d0923d55c9..2c006fe824 100644 --- a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/ValidateAntiforgeryTokenAuthorizationFilterTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/ValidateAntiforgeryTokenAuthorizationFilterTest.cs @@ -38,7 +38,7 @@ public async Task Filter_ValidatesAntiforgery_ForAllMethods(string httpMethod) var actionContext = new ActionContext(new DefaultHttpContext(), new RouteData(), new ActionDescriptor()); actionContext.HttpContext.Request.Method = httpMethod; - var context = new AuthorizationContext(actionContext, new[] { filter }); + var context = new AuthorizationFilterContext(actionContext, new[] { filter }); // Act await filter.OnAuthorizationAsync(context); @@ -62,7 +62,7 @@ public async Task Filter_SkipsAntiforgeryVerification_WhenOverridden() var actionContext = new ActionContext(new DefaultHttpContext(), new RouteData(), new ActionDescriptor()); actionContext.HttpContext.Request.Method = "POST"; - var context = new AuthorizationContext(actionContext, new IFilterMetadata[] + var context = new AuthorizationFilterContext(actionContext, new IFilterMetadata[] { filter, new IgnoreAntiforgeryTokenAttribute(), diff --git a/test/WebSites/CorsWebSite/Filters/AllRequestsBlockingAuthorizationFilter.cs b/test/WebSites/CorsWebSite/Filters/AllRequestsBlockingAuthorizationFilter.cs index 4368e45793..02c1c27207 100644 --- a/test/WebSites/CorsWebSite/Filters/AllRequestsBlockingAuthorizationFilter.cs +++ b/test/WebSites/CorsWebSite/Filters/AllRequestsBlockingAuthorizationFilter.cs @@ -10,7 +10,7 @@ namespace CorsWebSite [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, AllowMultiple = false, Inherited = true)] public class AllRequestsBlockingAuthorizationFilter : Attribute, IAuthorizationFilter { - public void OnAuthorization(AuthorizationContext context) + public void OnAuthorization(AuthorizationFilterContext context) { context.Result = new ContentResult() { diff --git a/test/WebSites/FiltersWebSite/Filters/AuthorizeUserAttribute.cs b/test/WebSites/FiltersWebSite/Filters/AuthorizeUserAttribute.cs index 1449c806b0..a3e91fdf8e 100644 --- a/test/WebSites/FiltersWebSite/Filters/AuthorizeUserAttribute.cs +++ b/test/WebSites/FiltersWebSite/Filters/AuthorizeUserAttribute.cs @@ -9,7 +9,7 @@ namespace FiltersWebSite { public class AuthorizeUserAttribute : AuthorizationFilterAttribute { - public override void OnAuthorization(AuthorizationContext context) + public override void OnAuthorization(AuthorizationFilterContext context) { if (context.ActionDescriptor.DisplayName == "FiltersWebSite.ProductsController.GetPrice") { diff --git a/test/WebSites/FiltersWebSite/Filters/BlockAnonymous.cs b/test/WebSites/FiltersWebSite/Filters/BlockAnonymous.cs index bb9fe3af2a..2d61e58b0b 100644 --- a/test/WebSites/FiltersWebSite/Filters/BlockAnonymous.cs +++ b/test/WebSites/FiltersWebSite/Filters/BlockAnonymous.cs @@ -7,7 +7,7 @@ namespace FiltersWebSite { public class BlockAnonymous : AuthorizationFilterAttribute { - public override void OnAuthorization(AuthorizationContext context) + public override void OnAuthorization(AuthorizationFilterContext context) { if (!HasAllowAnonymous(context)) { diff --git a/test/WebSites/FiltersWebSite/Filters/ControllerAuthorizationFilter.cs b/test/WebSites/FiltersWebSite/Filters/ControllerAuthorizationFilter.cs index 48a70a6098..de6f950198 100644 --- a/test/WebSites/FiltersWebSite/Filters/ControllerAuthorizationFilter.cs +++ b/test/WebSites/FiltersWebSite/Filters/ControllerAuthorizationFilter.cs @@ -8,7 +8,7 @@ namespace FiltersWebSite { public class ControllerAuthorizationFilter : AuthorizeUserAttribute { - public override void OnAuthorization(AuthorizationContext context) + public override void OnAuthorization(AuthorizationFilterContext context) { context.HttpContext.Response.Headers.Append("filters", "On Controller Authorization Filter - OnAuthorization"); } diff --git a/test/WebSites/FiltersWebSite/Filters/GlobalAuthorizationFilter.cs b/test/WebSites/FiltersWebSite/Filters/GlobalAuthorizationFilter.cs index ac943303c5..58818f329c 100644 --- a/test/WebSites/FiltersWebSite/Filters/GlobalAuthorizationFilter.cs +++ b/test/WebSites/FiltersWebSite/Filters/GlobalAuthorizationFilter.cs @@ -8,7 +8,7 @@ namespace FiltersWebSite { public class GlobalAuthorizationFilter : AuthorizationFilterAttribute { - public override void OnAuthorization(AuthorizationContext context) + public override void OnAuthorization(AuthorizationFilterContext context) { if (context.ActionDescriptor.DisplayName == "FiltersWebSite.ProductsController.GetPrice") { diff --git a/test/WebSites/FiltersWebSite/Filters/ThrowingAuthorizationFilter.cs b/test/WebSites/FiltersWebSite/Filters/ThrowingAuthorizationFilter.cs index 585e07fea0..ef355630d4 100644 --- a/test/WebSites/FiltersWebSite/Filters/ThrowingAuthorizationFilter.cs +++ b/test/WebSites/FiltersWebSite/Filters/ThrowingAuthorizationFilter.cs @@ -8,7 +8,7 @@ namespace FiltersWebSite { public class ThrowingAuthorizationFilter : AuthorizationFilterAttribute { - public override void OnAuthorization(AuthorizationContext context) + public override void OnAuthorization(AuthorizationFilterContext context) { throw new InvalidProgramException("Authorization Filter Threw"); }