Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

JsonInputFormatter and JsonOutputFormatter consistancy #2538

Closed
JamesNK opened this issue May 11, 2015 · 2 comments
Closed

JsonInputFormatter and JsonOutputFormatter consistancy #2538

JamesNK opened this issue May 11, 2015 · 2 comments
Assignees
@ajaybhargavb
Labels
3 - Done enhancement
Milestone
1.0.0-beta6

Comments

@JamesNK
Copy link
Member

JamesNK commented May 11, 2015

JsonInputFormatter
JsonOutputFormatter

  • On JsonInputFormatter the CreateJsonReader and CreateJsonSerializer method are public and virtual.
  • On JsonOutputFormatter the CreateJsonWriter and CreateJsonSerializer methods are private.

Should these methods be consistent between input and output formatters?

  • JsonOutputFormatter implements IJsonOutputFormatter
  • JsonInputFormatter doesn't implement an interface.

Is IJsonOutputFormatter required? It doesn't have any methods and is only used in one place.
@danroth27 danroth27 added this to the 6.0.0-beta6 milestone May 11, 2015
@danroth27
Copy link
Member

Let's deal with the IJsonOutputFormatter issue separately: #2715.

We should go ahead and make CreateJsonWriter and CreateJsonSerializer public.

@ajaybhargavb ajaybhargavb mentioned this issue Jun 22, 2015
Merged
@ajaybhargavb
Copy link
Contributor

4a4b8ec

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta6
Development

No branches or pull requests
3 participants
@JamesNK @ajaybhargavb @danroth27