Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Make RazorViewEngine.GetNormalizedRouteValue easier to use outside of Mvc #3108

Closed
pranavkm opened this issue Sep 8, 2015 · 3 comments
Closed

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Sep 8, 2015

https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Razor/RazorViewEngine.cs#L151-L192 - it is marked as internal so that other components inside Razor can use it. This would be useful for any user writing a custom view location expander (for instance #3096 where he'd need to get to the area value) or a custom view engine.

Would it make sense to move this method to Core? There's nothing about it that requires it to be present in RazorViewEngine.

cc @rynowak

@rynowak
Copy link
Member

rynowak commented Sep 8, 2015

I don't get why it should move to Core, but it makes sense to make it public. In general if something is internal for any reason other than unit testing, it should be public.

@danroth27
Copy link
Member

OK to make this public.

@danroth27 danroth27 added this to the 6.0.0-beta8 milestone Sep 8, 2015
@pranavkm
Copy link
Contributor Author

pranavkm commented Sep 8, 2015

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants