Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

PhysicalFileResult should not throw FileNotFoundExceptions for non-rooted paths #3295

Closed
pranavkm opened this issue Oct 9, 2015 · 1 comment
Closed

PhysicalFileResult should not throw FileNotFoundExceptions for non-rooted paths #3295

pranavkm opened this issue Oct 9, 2015 · 1 comment
Assignees
@ryanbrandenburg
Labels
3 - Done bug
Milestone
1.0.0-rc1

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Oct 9, 2015

Based on discussions here - #3290 (comment)

It's confusing for Mvc to throw a FileNotFoundException. Instead we should throw InvalidOperation or NotSupported so it's clear that the PhysicalFileResult does not support non-rooted paths.
@pranavkm pranavkm added the bug label Oct 9, 2015
@Eilon Eilon added the 1 - Ready label Oct 9, 2015
@Eilon Eilon added this to the 6.0.0-rc1 milestone Oct 9, 2015
@ryanbrandenburg
Copy link
Contributor

Fixed in #3308

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanbrandenburg ryanbrandenburg

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc1
Development

No branches or pull requests
3 participants
@pranavkm @Eilon @ryanbrandenburg