Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Rename ViewComponent.Context to HttpContext #3332

Closed
DmitrySikorsky opened this issue Oct 16, 2015 · 10 comments
Closed

Rename ViewComponent.Context to HttpContext #3332

DmitrySikorsky opened this issue Oct 16, 2015 · 10 comments
Assignees
Milestone

Comments

@DmitrySikorsky
Copy link

Because now we have this property named 'HttpContext' in the Controller, so it is strange to have different name in the ViewComponent.

@Muchiachio
Copy link
Contributor

And while we are on this, then RazorPage and ApiController too?

@DmitrySikorsky
Copy link
Author

Yes. I think they all have to have some one name.

@rynowak
Copy link
Member

rynowak commented Oct 16, 2015

For RazorPage and ApiController we need to be consistent with previous versions

@henkmollema
Copy link
Contributor

👍 this is pretty confusing at the moment: http://stackoverflow.com/q/33212908

@Eilon
Copy link
Member

Eilon commented Oct 20, 2015

@pranavkm can you have a look at the PR and merge?

@pranavkm
Copy link
Contributor

Thanks for the PR!

@henkmollema
Copy link
Contributor

You're welcome 😄
Does this need an announcement or some other breaking change notice?

@pranavkm
Copy link
Contributor

@danroth27, thoughts on the announcement question?

@rynowak
Copy link
Member

rynowak commented Oct 23, 2015

@pranavkm Might as well make an announcement grouping all of the similar changes we did like this, it's a change affecting a very common surface area 👍

@pranavkm
Copy link
Contributor

@rynowak could you point me to the "similar changes" so I could add it to the announcement?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants