CandidateAssemblies should always include the entry assembly?

[javiercn]

Scenario, I'm running MVC Sandbox and I get a 404 on startup.

Default assembly manager does this:
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/Infrastructure/DefaultAssemblyProvider.cs#L75

        public IEnumerable<Assembly> CandidateAssemblies
        {
            get
            {
                if (_dependencyContext == null)
                {
                    // Use the entry assembly as the sole candidate.
                    return new[] { _entryAssembly };
                }

                return GetCandidateLibraries()
                    .SelectMany(l => l.Assemblies)
                    .Select(Load);
            }
        }

GetCandidateLibraries only includes dependent assemblies (which for MVCSandbox only contains the MVC assemblies)

I believe the list of candidate assemblies should always contain the entry assembly plus optionally a set of referenced assemblies based on whether or not the DependencyContext is available.

[javiercn]

/cc @pranavkm

[pranavkm]

GetCandidateLibraries only includes dependent assemblies

That's not true though. It should include the entry assembly if it references Mvc. What's the specific issue you were seeing?

[javiercn]

Running MVCSandbox, the MVCSandbox assembly wouldn't be included. @pakrym is investigating and I believe he has more context

[pakrym]

This is fixed in latest Cli+DependencyModel, lets keep it open to track the issue

[Eilon]

If you have a bug/PR number that would be good.

[pakrym]

Fixed == It's not broken there. Cli and dependency model being out of sync in mvc causes it.

[pranavkm]

Yeah, I haven't noticed this using 1.0.0-beta-001718 CLI + the DependencyModel clone we have in Mvc.

[Eilon]

Ah so we think it's fixed in newer builds?

[pakrym]

Yes

[Eilon]

Ok, we'll just hold onto this issue until we can verify. Thanks!

[NTaylorMullen]

Using dotnetcli 001718 and finding that my applications runtime library does not have any listed assemblies for it when published. However, if I choose not to publish and do dotnet run all works fine.

[NTaylorMullen]

Alright, turns out this happens if you don't do .UseContentRoot(Directory.GetCurrentDirectory()) in your Main. Yay 😵

Ignore me.

[pranavkm]

Looks like this is fixed with the newest DependencyModel. @NTaylorMullen, the other issue is to make view discovery work and we could consider adding it to MvcSandbox to make our work flow bit easier.

[Eilon]

This is now fixed.