Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Remove ViewEngine property of ViewComponentResult (it doesn't do anything) #4916

Closed
cjqian opened this issue Jun 28, 2016 · 7 comments
Closed

Comments

@cjqian
Copy link
Contributor

cjqian commented Jun 28, 2016

No description provided.

@Eilon
Copy link
Member

Eilon commented Jun 28, 2016

@cjqian can you provide more info about this? Why it isn't needed anymore? Does the property not work anymore?

@cjqian
Copy link
Contributor Author

cjqian commented Jun 28, 2016

@rynowak

@rynowak
Copy link
Member

rynowak commented Jun 28, 2016

This wasn't really ever used for anything I don't think.

@Eilon
Copy link
Member

Eilon commented Jun 28, 2016

Well we can't remove it... Did it just always no-op or something?

@dougbu
Copy link
Member

dougbu commented Jun 30, 2016

Did it just always no-op or something?

There's exactly (0 + zero + nada) references to this property in the MVC repo. No reads; no writes.

@Eilon
Copy link
Member

Eilon commented Jun 30, 2016

Hmm, well, we can't remove it due to compatibility, just in case someone is calling it. But in the meantime we can certainly document it as serving no purpose. E.g. "This property is never set and should not be used. It will be removed in a future release." We can mark as Obsolete (warning, not error) with the same message as well.

@Eilon Eilon added this to the 2.0.0 milestone Jul 23, 2016
@Eilon Eilon changed the title ViewEngine property in ViewComponentResult is no longer needed. Remove ViewEngine property of ViewComponentResult (it doesn't do anything) Jul 23, 2016
@Eilon
Copy link
Member

Eilon commented Jul 23, 2016

I logged #5066 to mark the property as obsolete. Then we'll do the removal (this bug) in 2.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants