Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Treat an invalid charset identically to one a TextInputFormatter does not support #5501

Closed
dougbu opened this issue Nov 3, 2016 · 1 comment
Closed

Treat an invalid charset identically to one a TextInputFormatter does not support #5501

dougbu opened this issue Nov 3, 2016 · 1 comment
Assignees
@dougbu
Labels
3 - Done bug
Milestone
1.1.0

Comments

@dougbu
Copy link
Member

dougbu commented Nov 3, 2016

A Content-type header containing application/json;charset=garbage where the system had no configured Encoding for garbage is treated as if the Content-type header did not mention the charset at all. That is, the JsonInputFormatter attempted to deserialize the request body using its slight reconfiguration of Encoding.UTF8. Such cases should instead result in an HTTP/415, Unsupported Media Type response.

Found while investigating #5351 and fixed in original PR for that bug (#5415).
@dougbu dougbu self-assigned this Nov 3, 2016
@dougbu dougbu added this to the 1.1.0 milestone Nov 3, 2016
@dougbu dougbu added the bug label Nov 3, 2016
@dougbu
Copy link
Member Author

dougbu commented Nov 3, 2016

Fixed for good in f042865

@dougbu dougbu closed this as completed Nov 3, 2016
@dougbu dougbu added the 3 - Done label Nov 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@dougbu