Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Port to 2.0.1: Input fields don't emit (and thus round-trip) offset value when binding against DateTimeOffset fields #6834

Closed
Eilon opened this issue Sep 15, 2017 · 7 comments

Comments

@Eilon
Copy link
Member

Eilon commented Sep 15, 2017

Original bug we fixed in 2.1.0: #6648

Given that this change is slightly riskier, I recommend we add a quirk mode switch.

cc @DamianEdwards

@Eilon Eilon added this to the 2.0.1 milestone Sep 15, 2017
@Eilon
Copy link
Member Author

Eilon commented Sep 15, 2017

This patch bug is approved for the 2.0.x patch. Please send a PR to the feature/2.0.1 branch and get it reviewed and merged. When we have the rel/2.0.1 branches ready please port the commit to that branch.

@dougbu
Copy link
Member

dougbu commented Sep 18, 2017

6041c6b and fd9cb08 in feature/2.0.1

@dougbu
Copy link
Member

dougbu commented Sep 18, 2017

When we have the rel/2.0.1 branches ready please port the commit to that branch.

@Eilon to be clear: We're not merging all of feature/2.0.1 into rel/2.0.1 in one blast? Should I leave this bug open until I do that second port?

@dougbu
Copy link
Member

dougbu commented Sep 19, 2017

FYI same commits are now in rel/2.0.1.

@Eilon
Copy link
Member Author

Eilon commented Sep 19, 2017

We can do it whichever way. I think doing all in one blast is fine.

@Eilon
Copy link
Member Author

Eilon commented Sep 19, 2017

But leaving the bug closed is fine.

@Eilon
Copy link
Member Author

Eilon commented Oct 23, 2017

Hi, we have a public test feed that you can use to try out the ASP.NET/EF Core 2.0.3 patch!

To try out the pre-release patch, please refer to the following guide:

We are looking for feedback on this patch. We'd like to know if you have any issues with this patch by updating your apps and libraries to the latest packages and seeing if it fixes the issues you've had, or if it introduces any new issues. If you have any issues or questions, please reply on this issue to let us know as soon as possible.

Thanks,
Eilon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants