Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Visitors should not print out design time mappings for inherited chunks #945

Closed
pranavkm opened this issue Aug 6, 2014 · 4 comments
Closed

Visitors should not print out design time mappings for inherited chunks #945

pranavkm opened this issue Aug 6, 2014 · 4 comments
Assignees
@NTaylorMullen
Labels
bug duplicate
Milestone
1.0.0-beta8

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Aug 6, 2014

The SyntaxTreeNode and SourceLocation line mappings for an inherited chunk reflect the ones from the original _ViewStart and not the current page. Printing these out would be incorrect. Unfortunately setting it to null doesn't work since it causes some visitors to null ref.
@danroth27
Copy link
Member

@pranavkm What's the user impact of this issue?

@pranavkm
Copy link
Contributor Author

As far as I know, it doesn't seem to mess up VS. But we should fix this for RC since it's hoping VS does the right thing by ignoring incorrectly reported mappings.

@danroth27 danroth27 added this to the 6.0.0-rc1 milestone Oct 8, 2014
@yishaigalatzer yishaigalatzer modified the milestones: 6.0.0-rc1, 6.0.0-beta3 Jan 12, 2015
@danroth27 danroth27 modified the milestones: 6.0.0, 6.0.0-rc1 Mar 16, 2015
@Eilon Eilon modified the milestones: 6.0.0-beta6, 6.0.0-beta5 May 20, 2015
@Eilon Eilon modified the milestones: 6.0.0-beta7, 6.0.0-beta6 Jun 30, 2015
@Eilon Eilon modified the milestones: 6.0.0-beta8, 6.0.0-beta7 Aug 7, 2015
@pranavkm
Copy link
Contributor Author

Dup of #2321

@NTaylorMullen
Copy link
Contributor

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
bug duplicate
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
5 participants
@pranavkm @Eilon @yishaigalatzer @danroth27 @NTaylorMullen