Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Fix Microsoft.AspNet.Razor.Test failures when git config core.autocrlf true #438

Closed
dougbu opened this issue Jun 25, 2015 · 1 comment
Closed

Fix Microsoft.AspNet.Razor.Test failures when git config core.autocrlf true #438

dougbu opened this issue Jun 25, 2015 · 1 comment
Labels
task

Comments

@dougbu
Copy link
Member

dougbu commented Jun 25, 2015

On Windows systems with core.autocrlf set to true (not the default), 221 tests fail due to unexpected line endings in the files read from disc. Need a strong dose of the changes used to address aspnet/Mvc#1514.

Note this problem is specific to the combination described above. Microsoft.AspNet.Razor.Test runs clean on Linux systems. (I see an unrelated issue in Microsoft.AspNet.Razor.Runtime.Test but that may be specific to my system.)
@dougbu
Copy link
Member Author

dougbu commented Jun 25, 2015

Fix may be fairly narrow because relevant assertions are in just a few helper methods.

@Eilon Eilon modified the milestone: 4.0.0-beta7 Jul 1, 2015
@danroth27 danroth27 added the task label Jul 24, 2015
@Eilon Eilon modified the milestones: 4.0.0-beta7, 4.0.0-beta8 Aug 7, 2015
@Eilon Eilon modified the milestones: 4.0.0-beta8, 4.0.0-rc1 Sep 24, 2015
@Eilon Eilon modified the milestones: 4.0.0-rc1, 4.0.0-rc2 Oct 22, 2015
@Eilon Eilon modified the milestones: 4.0.0-rc2, Backlog Jan 22, 2016
@Eilon Eilon closed this as completed Jan 9, 2017
@rynowak rynowak removed this from the Backlog milestone Dec 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Eilon @rynowak @danroth27 @dougbu