Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

OrgAuth: Account Controller should return void #126

Closed
Eilon opened this issue Oct 24, 2017 · 2 comments
Closed

OrgAuth: Account Controller should return void #126

Eilon opened this issue Oct 24, 2017 · 2 comments
Assignees
@javiercn
Labels
investigate

Comments

@Eilon
Copy link
Member

Eilon commented Oct 24, 2017

From @rustd on June 12, 2015 22:17

Since aspnet/Mvc#2409 is fixed. We should change the AccountController for SSO/ MultiOrg to return void

Copied from original issue: aspnet/Templates#104
@Eilon Eilon added the bug label Oct 24, 2017
@Eilon Eilon mentioned this issue Oct 24, 2017
Closed
@aspnet aspnet deleted a comment from tonydrake Mar 5, 2018
@Eilon
Copy link
Member Author

Eilon commented Mar 5, 2018

@javiercn - thoughts on this?

@Eilon Eilon added investigate and removed bug labels Mar 5, 2018
@javiercn
Copy link
Member

javiercn commented Mar 5, 2018

Our account controller returns action results to signal the middleware what to do. Using action results makes it easier to unit test and its the recommended pattern. Updating from an MVC5 app will already require you to significantly change the auth code, so I don't think we should neither do this nor that there is value here.

I'm closing it.

@javiercn javiercn closed this as completed Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@javiercn javiercn

Labels
investigate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eilon @javiercn