New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use errgroup in server #295

Closed

BrianHicks opened this issue Sep 22, 2016 · 1 comment · Fixed by #363

Labels

enhancement Hacktoberfest tiny

Contributor

BrianHicks commented Sep 22, 2016

Probably an improvement over what we're doing now and it has context support. https://godoc.org/golang.org/x/sync/errgroup#ex-Group--Pipeline

BrianHicks added enhancement tiny labels

BrianHicks added the Hacktoberfest label

Contributor Author

BrianHicks commented Sep 29, 2016

To be clear: this should happen in cmd/server.go

QuentinPerez mentioned this issue

cmd/server.go: use errgroup instead of waitgroup #363

Merged

BrianHicks closed this as completed in #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment